-
Notifications
You must be signed in to change notification settings - Fork 314
Merge | SqlConnection.cs #3608
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge | SqlConnection.cs #3608
Conversation
This isn't in the right place - see dotnet#3029.
This is a holdover from the removal of SQLCLR support
XML documentation reference cleanup to follow
/azp run |
Azure Pipelines successfully started running 2 pipeline(s). |
The target adds an obsolete attribute to generated code, and this blocks compilation
Thanks - I've just spotted the problem, could someone re-run CI please? |
/azp run |
Azure Pipelines successfully started running 2 pipeline(s). |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3608 +/- ##
==========================================
- Coverage 65.48% 60.31% -5.18%
==========================================
Files 275 269 -6
Lines 61518 60465 -1053
==========================================
- Hits 40288 36469 -3819
- Misses 21230 23996 +2766
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good, got a couple questions, but glad to move forward with it as-is
src/Microsoft.Data.SqlClient/netfx/src/Microsoft/Data/SqlClient/SqlConnection.cs
Show resolved
Hide resolved
src/Microsoft.Data.SqlClient/netfx/src/Microsoft/Data/SqlClient/SqlConnection.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Data.SqlClient/netfx/src/Microsoft/Data/SqlClient/SqlConnection.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Data.SqlClient/netfx/src/Microsoft/Data/SqlClient/SqlConnection.cs
Show resolved
Hide resolved
src/Microsoft.Data.SqlClient/netfx/src/Microsoft/Data/SqlClient/SqlConnection.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again for all your work on this! 🚀 🚀
/azp run |
Azure Pipelines successfully started running 2 pipeline(s). |
Description
This merges the SqlConnection class. I recommend reviewing this commit-by-commit with whitespace changes disabled; the underlying changes are pretty minor.
Earlier PRs have already addressed all of the breaking changes, so each commit handles a fairly small change needed to render the files identical. By b966f7a, these files are ready to merge.
I've tried to avoid functional changes. As a result, I noticed a handful of sections which enabled WindowsIdentity impersonation and have conditionally compiled them for netfx. These would probably work for netcore, but I don't have ready access to a domain from Windows and Linux and so can't test them.
On one final point, this doesn't deal with the SqlConnectionHelper.cs file. That file remains target-specific, it's too difficult to merge a sensible without dealing with the main SqlConnection.cs file first.
Issues
Relates to #1261.
Ports #378 and #379 from netcore to netfx.
Testing
Automated tests run.
Could someone run CI please?