InternalsVisibleTo In Nonstandard Location

[benrr101]

Description: In SqlConnection, there is an [assembly:InternalsVisibleTo...] attribute tucked at the beginning of the class. This is more/less in a non-standard location and makes was an unexpected surprise when I spotted it.

Fix: Move all InternalsVisibleTo attributes to AssemblyInfo.cs

[edwardneal]

I agree. The current InternalsVisibleTo attribute is:

[assembly: InternalsVisibleTo("System.Data.DataSetExtensions, PublicKey=" + Microsoft.Data.SqlClient.AssemblyRef.EcmaPublicKeyFull)]
// NOTE: The current Microsoft.VSDesigner editor attributes are implemented for System.Data.SqlClient, and are not publicly available.
// New attributes that are designed to work with Microsoft.Data.SqlClient and are publicly documented should be included in future.

Which internals does System.Data.DataSetExtensions need to use though? I read the comment as an indicator that the VS designer is currently linked against System.Data.SqlClient, so the InternalsVisibleTo attribute isn't in use. It might be worth reviewing the internal classes that System.Data.DataSetExtensions needs to reference and considering what public API surface could replace those references; without that, we can't make any variable naming changes to internal classes without risking breaking Visual Studio.