[6.1] Stabilize CI Pipelines #3601
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fixed the unique name generators to: - Keep max lengths to 30 and 96 characters respectively. - Ensure uniqueness at the start of the names. - Added link to database identifier syntax.
There was a problem hiding this comment.
Pull Request Overview
This PR fixes issues with unique database object name generation in SQL Server tests by replacing inconsistent naming methods with standardized ones. The changes ensure proper name length limits and improve uniqueness generation for test database objects.
- Replace
GetUniqueName()calls withGetShortName()for objects requiring 30-character limits - Replace
GetUniqueNameForSqlServer()calls withGetLongName()for objects supporting 96-character limits - Update
DataTestUtilitywith improved name generation algorithms using GUID parts for better uniqueness
Reviewed Changes
Copilot reviewed 33 out of 33 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| DataTestUtility.cs | Implements new GetShortName() and GetLongName() methods with proper length constraints and GUID-based uniqueness |
| Various test files | Update method calls from old naming functions to new standardized ones based on required name length limits |
src/Microsoft.Data.SqlClient/tests/ManualTests/SQL/ParameterTest/ParametersTest.cs
Show resolved
Hide resolved
src/Microsoft.Data.SqlClient/tests/ManualTests/SQL/ParameterTest/ParametersTest.cs
Show resolved
Hide resolved
src/Microsoft.Data.SqlClient/tests/ManualTests/SQL/ParameterTest/ParametersTest.cs
Show resolved
Hide resolved
- Added missing using for Common.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release/6.1 #3601 +/- ##
===============================================
+ Coverage 69.69% 70.01% +0.31%
===============================================
Files 281 279 -2
Lines 62413 61748 -665
===============================================
- Hits 43500 43232 -268
+ Misses 18913 18516 -397
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
benrr101
previously approved these changes
Sep 8, 2025
…ssary test failures when the host VM is just slow.
* Account for MAX_DISPATCH_LATENCY in XEvents tests XEvents are asynchronous, and are written to the target within MAX_DISPATCH_LATENCY seconds. We therefore need to wait that long before querying the target. * Filter XEvent session by client_connection_id
paulmedynski
changed the title
samsharma2700
approved these changes
Sep 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Port of #3597.