Fix unique db object name issues #3597
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fixed the unique name generators to: - Keep max lengths to 30 and 96 characters respectively. - Ensure uniqueness at the start of the names.
- Increased long name suffix to 32 characters.
There was a problem hiding this comment.
Pull Request Overview
This PR fixes unique database object name generation in the SqlClient test suite to resolve maximum length issues and ensure proper uniqueness. The changes update various test files to use new naming methods (GetShortName and GetLongName) instead of the deprecated GetUniqueName and GetUniqueNameForSqlServer methods.
- Updates name generators to maintain maximum lengths of 30 and 96 characters respectively
- Replaces deprecated naming methods across all test files with appropriate alternatives
- Implements new uniqueness generation logic using GUID parts and consistent formatting
Reviewed Changes
Copilot reviewed 32 out of 32 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| DataTestUtility.cs | Core implementation of new GetShortName and GetLongName methods with proper length limits |
| VectorTypeBackwardCompatibilityTests.cs | Updated vector test table and procedure names to use GetShortName |
| NativeVectorFloat32Tests.cs | Updated vector test names to use GetShortName |
| Multiple UdtTest files | Updated UDT test names to use GetLongName for tables and procedures |
| Multiple SqlBulkCopyTest files | Updated bulk copy test names to use appropriate naming methods |
| Multiple other test files | Systematic replacement of deprecated naming methods across test suite |
src/Microsoft.Data.SqlClient/tests/ManualTests/DataCommon/DataTestUtility.cs
Outdated
Show resolved
Hide resolved
…TestUtility.cs Co-authored-by: Copilot <[email protected]>
- Replaced range operators with Substring() since .NET Framework doesn't have ranges.
mdaigle
reviewed
Sep 3, 2025
src/Microsoft.Data.SqlClient/tests/ManualTests/DataCommon/DataTestUtility.cs
Outdated
Show resolved
Hide resolved
mdaigle
reviewed
Sep 3, 2025
src/Microsoft.Data.SqlClient/tests/ManualTests/DataCommon/DataTestUtility.cs
Outdated
Show resolved
Hide resolved
- Replaced '-' with '_' to avoid T-SQL syntax issues.
mdaigle
reviewed
Sep 3, 2025
src/Microsoft.Data.SqlClient/tests/ManualTests/DataCommon/DataTestUtility.cs
Outdated
Show resolved
Hide resolved
- Swapped the suffix into a prefix. - Added debugging to see what the names look like when failures occur.
paulmedynski
commented
Sep 3, 2025
src/Microsoft.Data.SqlClient/tests/ManualTests/DataCommon/DataTestUtility.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Data.SqlClient/tests/ManualTests/DataCommon/DataTestUtility.cs
Outdated
Show resolved
Hide resolved
- Removed debugging console emission, since it breaks fragile tests! - Added link to database identifier syntax.
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
benrr101
approved these changes
Sep 4, 2025
src/Microsoft.Data.SqlClient/tests/ManualTests/DataCommon/DataTestUtility.cs
Show resolved
Hide resolved
mdaigle
approved these changes
Sep 4, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3597 +/- ##
==========================================
+ Coverage 65.48% 66.31% +0.82%
==========================================
Files 275 275
Lines 61518 61518
==========================================
+ Hits 40288 40797 +509
+ Misses 21230 20721 -509
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
apoorvdeshmukh
approved these changes
Sep 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description