Skip to content

Do not use for loops for package removal on debian-based systems #20271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Do not use for loops for package removal on debian-based systems #20271

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion content/engine/install/debian.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ conflicts with the versions bundled with Docker Engine.
Run the following command to uninstall all conflicting packages:

```console
$ for pkg in docker.io docker-doc docker-compose podman-docker containerd runc; do sudo apt-get remove $pkg; done
$ sudo apt-get remove docker.io docker-doc docker-compose podman-docker containerd runc
Copy link
Member

@thaJeztah thaJeztah Jun 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using a loop was an intentional change; without a loop, this command may fail, and some packages still installed; see

resulting in having to confirm every uninstallation.

Yeah, that's rather inconvenient, and II can see that being inconvenient. Not sure what a better solutions would be for that, without this step becoming overly complex. We could detect which packages are installed, but probably that would make it either an extra step, or "complex",

If your situation allows it, and needs to be run non-interactively, it's of course use your own variant 😅

Copy link
Author

@ghost ghost Jun 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've just looked to these issues, and tested a few package removal combinations. Turns out, apt-get only fails if a package does not exist. That is, when there is no such package in the package repository. When a real package is not installed, apt continues normally:

$ sudo apt-get remove docker.io podman-docker
Reading package lists... Done
Building dependency tree... Done
Reading state information... Done
Package 'podman-docker' is not installed, so not removed
...
The following packages will be REMOVED:
  docker.io
0 upgraded, 0 newly installed, 1 to remove and 0 not upgraded.
After this operation, 151 MB disk space will be freed.
Do you want to continue? [Y/n]

According to docs itself, these guides are for debian 11 or higher, ubuntu 20.04 or higher, and their derivatives. All of the packages in the changed lines are in the repositories already. So, I think my change would not break something, or would it?

In #17405, the problem was related with nonexistent docker-engine package. Looks like that package is already removed from here.

Copy link
Contributor

@dvdksn dvdksn Sep 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure when the docker-engine package was removed from here but indeed, apt-get will only skip and not error out if the package exists but was not installed. Given that we don't list any nonexistent packages here, I think we should be safe to remove the for-loop now. WDYT @thaJeztah?

Besides, it's been a pretty long time since we shipped packages under those nonexistent (e.g. docker-engine) names, no? We're only backwards compatible with oldstable, so this should be fine I think.

```

`apt-get` might report that you have none of these packages installed.
Expand Down
2 changes: 1 addition & 1 deletion content/engine/install/raspberry-pi-os.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ conflicts with the versions bundled with Docker Engine.
Run the following command to uninstall all conflicting packages:

```console
$ for pkg in docker.io docker-doc docker-compose podman-docker containerd runc; do sudo apt-get remove $pkg; done
$ sudo apt-get remove docker.io docker-doc docker-compose podman-docker containerd runc
```

`apt-get` might report that you have none of these packages installed.
Expand Down
2 changes: 1 addition & 1 deletion content/engine/install/ubuntu.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ conflicts with the versions bundled with Docker Engine.
Run the following command to uninstall all conflicting packages:

```console
$ for pkg in docker.io docker-doc docker-compose docker-compose-v2 podman-docker containerd runc; do sudo apt-get remove $pkg; done
$ sudo apt-get remove docker.io docker-doc docker-compose docker-compose-v2 podman-docker containerd runc
```

`apt-get` might report that you have none of these packages installed.
Expand Down