engine: fix apt-get remove command for uninstall preexisting packages #17415
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docsdocker ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
1 task
vvoland
reviewed
May 25, 2023
dvdksn
force-pushed
the
engine/aptget-remove-fix
branch
from
7b3498e to
4324bb2
Compare
vvoland
previously approved these changes
May 26, 2023
engine/install/debian.md
Outdated
| ``` | ||
|
|
||
| `apt-get` might report that you have none of these packages installed. | ||
| That's fine. |
Contributor
There was a problem hiding this comment.
Suggested change
| That's fine. |
Not sure that's necessary, but in these cases I've never been sure what else to use… Possibly just nothing is best
dvdksn
force-pushed
the
engine/aptget-remove-fix
branch
from
4324bb2 to
1e3e693
Compare
thaJeztah
reviewed
May 26, 2023
thaJeztah
reviewed
May 26, 2023
dvdksn
force-pushed
the
engine/aptget-remove-fix
branch
from
1e3e693 to
a8ec976
Compare
Contributor
Author
|
@thaJeztah PTAL! I've updated to remove the dated packages and included the other potential conflicts you mentioned |
thaJeztah
reviewed
May 26, 2023
engine/install/debian.md
Outdated
| - `docker-doc` | ||
| - `podman-docker` | ||
|
|
||
| Moreover, Docker Engine depends on `containerd` or `runc`. Docker Engine |
Member
There was a problem hiding this comment.
Suggested change
| Moreover, Docker Engine depends on `containerd` or `runc`. Docker Engine | |
| Moreover, Docker Engine depends on `containerd` and `runc`. Docker Engine |
thaJeztah
reviewed
May 26, 2023
Member
thaJeztah
left a comment
thaJeztah
left a comment
There was a problem hiding this comment.
one comment (applies to all files), but otherwise LGTM 👍 (looks much better thanks!)
Signed-off-by: David Karlsson <[email protected]>
dvdksn
force-pushed
the
engine/aptget-remove-fix
branch
from
a8ec976 to
2aa6ad3
Compare
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: David Karlsson [email protected]
Proposed changes
The
apt-get removecommand in docs for removing old versions of docker engine and deps would fail if a package isn't found.This changes the command to remove the packages one-by-one
Related issues (optional)
Closes #17405