Skip to content

[CI] Move to the latest release of the get-release action #7279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 28, 2022
Merged

[CI] Move to the latest release of the get-release action #7279

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/release-packages.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ jobs:
echo "deb_package_name=ubuntu-20.04-$deb_package_name" >> $GITHUB_OUTPUT
- name: Get release info
id: get_release_info
uses: bruceadams/get-release@v1
uses: bruceadams/get-release@v1.3.2
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is surprising to me: isn't this what you get by default (assuming 1.3.2 is the most recent version of v1)?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Michael, sorry for late response:

This ended up being needed - I'm not entirely sure why though. There appear to be multiple reports in other projects as well, for instance -> actions/setup-node#211

I think what happens is that there's two levels of tags that need to have a close correspondence for the shorthand version to work. It may be that the author of this action made a mistake and broke that correspondence between the tags, and this is why the version wasn't being found when it was looked up in a registry by GitHub Actions.

But this is me speculating based on the fix, other reports and some documentation - I'm not entirely sure about the root cause.

- name: Upload binary packages
uses: actions/upload-release-asset@v1
with:
Expand Down Expand Up @@ -151,7 +151,7 @@ jobs:
echo "deb_package_name=ubuntu-18.04-$deb_package_name" >> $GITHUB_OUTPUT
- name: Get release info
id: get_release_info
uses: bruceadams/get-release@v1
uses: bruceadams/get-release@v1.3.2
- name: Upload binary packages
uses: actions/upload-release-asset@v1
with:
Expand Down Expand Up @@ -281,7 +281,7 @@ jobs:
& signtool.exe verify /pa ${{ steps.create_packages.outputs.msi_installer }}
- name: Get release info
id: get_release_info
uses: bruceadams/get-release@v1
uses: bruceadams/get-release@v1.3.2
- name: Upload binary packages
uses: actions/upload-release-asset@v1
with:
Expand Down