Skip to content

[CI] Move to the latest release of the get-release action #7279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 28, 2022

Conversation

NlightNFotis
Copy link
Contributor

The get-release action at version 1 has now been deleted, and as a result our latest release package building errors out with "unable to find version 1".

This should fix the problem.

  • Each commit message has a non-empty body, explaining why the change was made.
  • Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • White-space or formatting changes outside the feature-related changed lines are in commits of their own.

@NlightNFotis NlightNFotis requested a review from a team as a code owner October 27, 2022 21:30
@codecov
Copy link

codecov bot commented Oct 27, 2022

Codecov Report

Base: 78.03% // Head: 78.03% // No change to project coverage 👍

Coverage data is based on head (446b00c) compared to base (ab2b0cb).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #7279   +/-   ##
========================================
  Coverage    78.03%   78.03%           
========================================
  Files         1624     1624           
  Lines       187405   187405           
========================================
  Hits        146249   146249           
  Misses       41156    41156           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@TGWDB TGWDB merged commit 8986442 into diffblue:develop Oct 28, 2022
@NlightNFotis NlightNFotis deleted the fix_release_package_actions branch October 28, 2022 09:09
@@ -63,7 +63,7 @@ jobs:
echo "deb_package_name=ubuntu-20.04-$deb_package_name" >> $GITHUB_OUTPUT
- name: Get release info
id: get_release_info
uses: bruceadams/get-release@v1
uses: bruceadams/get-release@v1.3.2
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is surprising to me: isn't this what you get by default (assuming 1.3.2 is the most recent version of v1)?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Michael, sorry for late response:

This ended up being needed - I'm not entirely sure why though. There appear to be multiple reports in other projects as well, for instance -> actions/setup-node#211

I think what happens is that there's two levels of tags that need to have a close correspondence for the shorthand version to work. It may be that the author of this action made a mistake and broke that correspondence between the tags, and this is why the version wasn't being found when it was looked up in a registry by GitHub Actions.

But this is me speculating based on the fix, other reports and some documentation - I'm not entirely sure about the root cause.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants