Porting of the function pointer restriction feature to variable sensitivity domain branch. #5309
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
NlightNFotis
commented
Apr 20, 2020
NlightNFotis
commented
- Each commit message has a non-empty body, explaining why the change was made.
- Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
- The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
- Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
- My commit message includes data points confirming performance improvements (if claimed).
- My PR is restricted to a single feature or bugfix.
- White-space or formatting changes outside the feature-related changed lines are in commits of their own.
NlightNFotis
requested review from
chrisr-diffblue,
danpoe,
hannes-steffenhagen-diffblue,
kroening,
martin-cs,
peterschrammel,
pkesseli,
smowton and
tautschnig
as code owners
NlightNFotis
force-pushed
the
feature/vsd-port-of-restrict-function-pointer
branch
3 times, most recently
from
631b641 to
33d9898
Compare
hannes-steffenhagen-diffblue
suggested changes
Apr 22, 2020
hannes-steffenhagen-diffblue
changed the base branch from
variable-sensitivity-domain
to
variable-sensitivity-with-get-function-pointers
hannes-steffenhagen-diffblue
approved these changes
Apr 22, 2020
thk123
reviewed
Apr 23, 2020
unit/Makefile
Outdated
| @@ -23,6 +23,8 @@ SRC += analyses/ai/ai.cpp \ | |||
| analyses/variable-sensitivity/last_written_location.cpp \ | |||
| big-int/big-int.cpp \ | |||
| compound_block_locations.cpp \ | |||
| get_goto_model_from_c_test.cpp \ | |||
| goto-instrument/cover_instrument.cpp \ | |||
There was a problem hiding this comment.
Noting this line is different from original commit
There was a problem hiding this comment.
🚫 in fact - this shouldn't be here, the line is included two lines down
There was a problem hiding this comment.
Good spot, fixed
The function takes a C program (as a string or an input stream) and converts it to a goto model.
This adds a new option, --restrict-function-pointer, to goto-instrument. This lets a user specify a list of possible pointer targets for specific function pointer call sites, rather than have remove_function_pointers guess possible values. The intended purpose behind this is to prevent excessive symex time wasted on exploring paths the user knows the program can never actually take.
Update to reflect that the feature is now a goto-instrument analysis
This works similar to restrict-function-pointer, but for names of individual function pointer variables (globals, locals, parameters) rather than call sites. This isn't applicable to all situations (for example, calling function pointers in structs or function pointers returned from functions), but is more readily applicable to some common use scenarios (e.g. global function pointers loaded at start time like in OpenGL).
- remove unnecessary loop - make it return the restriction instead of inserting it into the map
NlightNFotis
force-pushed
the
feature/vsd-port-of-restrict-function-pointer
branch
from
33d9898 to
45d171f
Compare
thk123
approved these changes
Apr 23, 2020
NlightNFotis
merged commit 0d9c35f
into
diffblue:variable-sensitivity-with-get-function-pointers
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.