Add support for exporting function pointer targets at all callsites. #5289
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
as a new abstract object.
There is no value in wrapping an object with no additional information, and there is currently some problems with wrapping
There is currently some inconsistency between how the value set and the interval domains handle wrapping. Specifically, the value set returns an unwrapped object when eval'd, whereas the interval domain returns a wrapped object. Since the rest of the code is compatible with the interval suggestion, we temporarily disable wrapping if using value set
The variable sensitivity domain is always on, if we're using the variable sensitivity domain object factory
Use from_expr instead of constant_expr::get_value() so we don't print hex values
for the new value-set abstraction.
for the new value-set abstraction.
…cpp" This reverts commit cac98ce
It was written in 2017 but was #if 0-ed out, so it needs to be updated to compile now. ADA-496 has been filed to fix this test up and reintroduce it.
This adds a new option, --restrict-function-pointer, to goto-instrument. This lets a user specify a list of possible pointer targets for specific function pointer call sites, rather than have remove_function_pointers guess possible values. The intended purpose behind this is to prevent excessive symex time wasted on exploring paths the user knows the program can never actually take.
Add --get-fp-values option to goto-analyzer for all callsites in json format to be fed to goto-instrument.
NlightNFotis
requested review from
cesaro,
chrisr-diffblue,
cristina-david,
danpoe,
hannes-steffenhagen-diffblue,
kroening,
martin-cs,
peterschrammel,
pkesseli,
smowton,
tautschnig and
thk123
as code owners
|
Please only review be933ca, the rest are from other PRs and will probably go away/change anyway. |
Co-authored-by: hannes-steffenhagen-diffblue <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an extra flag to
goto-analyzerthat allows it to write function pointer targets for all call sites in a json format, like this:{ "use_f.function_pointer_call.1": [ "f", "h", "g" ] }IMPORTANT: This PR's contributions is the two last commits.