Skip to content

fix: HTTP request/response handling in SyncJamfProtectPlans #782

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 12, 2025
Merged

fix: HTTP request/response handling in SyncJamfProtectPlans #782

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 6 additions & 8 deletions sdk/jamfpro/jamfproapi_jamf_protect.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -225,19 +225,17 @@ func (c *Client) GetJamfProtectPlans(params url.Values) (*ResponseJamfProtectPla
func (c *Client) SyncJamfProtectPlans() error {
endpoint := fmt.Sprintf("%s/plans/sync", uriJamfProtect)

var errorResponse SharedResourcResponseError
resp, err := c.HTTP.DoRequest("POST", endpoint, nil, &errorResponse)
if err != nil {
return fmt.Errorf(errMsgFailedUpdate, "sync Jamf Protect plans", err)
resp, _ := c.HTTP.DoRequest("POST", endpoint, nil, nil)
if resp == nil {
return fmt.Errorf("failed to sync Jamf Protect plans: no response received")
}

if resp != nil && resp.Body != nil {
if resp.Body != nil {
defer resp.Body.Close()
}

// Check if the response contains errors
if errorResponse.HTTPStatus != 0 {
return fmt.Errorf("failed to sync Jamf Protect plans: HTTP %d - %+v", errorResponse.HTTPStatus, errorResponse.Errors)
if resp.StatusCode != 204 {
return fmt.Errorf("failed to sync Jamf Protect plans: unexpected status code %d", resp.StatusCode)
}

return nil
Expand Down
Loading