Skip to content

Conversation

@neilmartin83
Copy link
Contributor

Change

Thank you for your contribution !
Please include a summary of the change and which issue is fixed.
Please also include relevant motivation and context.
List any dependencies that are required for this change.

The /v1/jamf-protect/plans/sync endpoint is a bit different from others.

  • It accepts an empty POST
  • It returns a response code and header but no body.

This change removes any checking of the response body in the function and instead we make sure we receive a 204 response code, indicating success. Any other response codes indicates a failure. Function works as expected now for doing a one-off Jamf Protect Plan sync.

Type of Change

Please DELETE options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update (Wiki)
  • Refactor (refactoring code, removing code, changing code structure)

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • My corresponding pipelines / checks run clean and green without any errors or warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (readme)
  • I did format my code

@neilmartin83 neilmartin83 requested a review from ShocOne as a code owner May 12, 2025 09:12
@thejoeker12 thejoeker12 merged commit 6db7da4 into deploymenttheory:main May 12, 2025
2 of 4 checks passed
@neilmartin83 neilmartin83 deleted the nm-jamfprotect-2025-05-12 branch May 12, 2025 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants