Merge branch 'master' into '6.0/stage' #262
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Streamline the per-vdev histogram reporting by directly using the data in vdev_mg->mg_histogram rather than "rolling up" the data from individual metaslab histogram data.
Addresses issue #258 The function used for a null pointer check is sdb.get_typed_null() e.g. if msp.ms_sm == sdb_get_typed_null(msp.ms_sm.type_): This is awkward and confusing. The new sdb.is_null() iterface simplifies the null check: if sdb.is_null(msp.ms_sm):
W0221: Parameters differ from overridden 'pretty_print' method (arguments-differ) Occurring at: sdb/commands/zfs/vdev.py:72 sdb/commands/zfs/metaslab.py:163 sdb/commands/zfs/spa.py:68 sdb/commands/zfs/dbuf.py:84 When overriding methods the arguments must match exactly. Introduced print_indented() method for Metaslab and Vdev classes.
Cleanup vdev histogram
Some jobs have been failing recently because the local Azure repos in the containers that our actions run were out of date and missing packages.
gh-actions: always update apt repos before installing packages
[1] Point out the common pitfall for libkdumpfile support in drgn [2] Point out that there is a project wiki
Update README.md
Codecov Report
@@ Coverage Diff @@
## 6.0/stage #262 +/- ##
=============================================
- Coverage 87.60% 87.51% -0.09%
=============================================
Files 62 62
Lines 2541 2523 -18
=============================================
- Hits 2226 2208 -18
Misses 315 315
Continue to review full report at Codecov.
|
prakashsurya
approved these changes
Mar 9, 2021
The histogram approximate median is calculated as about double what it should be. When we are on the bucket that goes past the median, the histogram is the *previous* bucket, plus part of this bucket. Signed-off-by: Matthew Ahrens <[email protected]>
sdimitro
approved these changes
Mar 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.