Cleanup vdev histogram #261
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Streamline the per-vdev histogram reporting by directly using the data in vdev_mg->mg_histogram rather than "rolling up" the data from individual metaslab histogram data.
ahrens
approved these changes
Feb 25, 2021
Addresses issue delphix#258 The function used for a null pointer check is sdb.get_typed_null() e.g. if msp.ms_sm == sdb_get_typed_null(msp.ms_sm.type_): This is awkward and confusing. The new sdb.is_null() iterface simplifies the null check: if sdb.is_null(msp.ms_sm):
mmaybee
force-pushed
the
cleanup_vdev_histogram
branch
from
f48f694 to
47a9f8a
Compare
Codecov Report
@@ Coverage Diff @@
## master #261 +/- ##
==========================================
- Coverage 87.60% 87.51% -0.09%
==========================================
Files 62 62
Lines 2541 2523 -18
==========================================
- Hits 2226 2208 -18
Misses 315 315
Continue to review full report at Codecov.
|
sdimitro
approved these changes
Feb 26, 2021
W0221: Parameters differ from overridden 'pretty_print' method (arguments-differ) Occurring at: sdb/commands/zfs/vdev.py:72 sdb/commands/zfs/metaslab.py:163 sdb/commands/zfs/spa.py:68 sdb/commands/zfs/dbuf.py:84 When overriding methods the arguments must match exactly. Introduced print_indented() method for Metaslab and Vdev classes.
mmaybee
force-pushed
the
cleanup_vdev_histogram
branch
from
515f9d2 to
92532a3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Please check if your PR fulfills the following requirements:
Pull request type
Please check the type of change your PR introduces:
What is the current behavior?
This PR includes two changes:
vdev.vdev_mg.mg_histogram.sdb.get_typed_null():This is both awkward and confusing.
Issue Number: 258
What is the new behavior?
vdev.vdev_mg.mg_histogramsdb.is_null()interface:Does this introduce a breaking change?