Skip to content

pylint upgrade: fix new warnings #218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 27, 2020
Merged

pylint upgrade: fix new warnings #218

merged 1 commit into from
Apr 27, 2020

Conversation

@sdimitro
Copy link
Contributor

@sdimitro sdimitro commented Apr 27, 2020

Issues before:

$ python3 -m pylint -d duplicate-code -d invalid-name sdb
************* Module sdb.command
sdb/command.py:148:22: W1309: Using an f-string that does not have any interpolated variables (f-string-without-interpolation)
************* Module sdb.commands.zfs.histograms
sdb/commands/zfs/histograms.py:146:18: W1309: Using an f-string that does not have any interpolated variables (f-string-without-interpolation)

-------------------------------------------------------------------
Your code has been rated at 9.99/10 (previous run: 10.00/10, -0.00)

@sdimitro sdimitro merged commit ce21c64 into delphix:master Apr 27, 2020
sdimitro added a commit that referenced this pull request May 4, 2020
@github-actions @sdimitro
Merge branch 'master' into '6.0/stage' (#220)
addf0f6 
* pylint upgrade: fix new warnings (#218)

* Migrate "sync-with-master" to use "delphix/actions" (#217)

Co-authored-by: Serapheim Dimitropoulos <[email protected]>
Co-authored-by: Prakash Surya <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@prakashsurya prakashsurya prakashsurya approved these changes

+1 more reviewer

@shartse shartse shartse approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sdimitro @prakashsurya @shartse