Skip to content

Conversation

@prakashsurya
Copy link
Contributor

No description provided.

Copy link
Contributor

@sdimitro sdimitro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pylint problems don't seem related - will open a PR soon

@sdimitro
Copy link
Contributor

Pylint issues should be gone, feel free to push after rebasing and ensuring that the tests pass

@prakashsurya
Copy link
Contributor Author

I need to get reviews and land the action PR before landing, too: delphix/actions#1

@codecov-io
Copy link

Codecov Report

Merging #217 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #217   +/-   ##
=======================================
  Coverage   86.75%   86.75%           
=======================================
  Files          59       59           
  Lines        2401     2401           
=======================================
  Hits         2083     2083           
  Misses        318      318           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ce21c64...0c21db8. Read the comment docs.

@prakashsurya prakashsurya merged commit 0e1988e into delphix:master Apr 28, 2020
sdimitro added a commit that referenced this pull request May 4, 2020
* pylint upgrade: fix new warnings (#218)

* Migrate "sync-with-master" to use "delphix/actions" (#217)

Co-authored-by: Serapheim Dimitropoulos <[email protected]>
Co-authored-by: Prakash Surya <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants