Skip to content

LB-291 Review delphix-kernel package dependencies #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 7, 2020
Merged

LB-291 Review delphix-kernel package dependencies #14

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions debian/control.aws.in
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,12 +31,14 @@ Standards-Version: 4.1.2
Package: delphix-kernel-@@KVERS@@
Provides: delphix-kernel-aws, delphix-kernel
Architecture: any
Depends: linux-aws,
linux-tools-aws,
Depends: linux-image-@@KVERS@@,
Copy link

@sebroy sebroy May 4, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like with this change, all platform-specific kernel packages share the exact same set of dependencies. Is there a way to consolidate and reduce the duplication?

Copy link
Contributor Author

@pzakha pzakha May 5, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, we can use a single file instead. I wanted to hold on this for now in case we need to add other packages for some of the platforms, but I can also go ahead with that change if you think it's better to do it now.

linux-image-@@KVERS@@-dbgsym,
linux-modules-extra-@@KVERS@@,
linux-headers-@@KVERS@@,
linux-tools-@@KVERS@@,
zfs-modules-@@KVERS@@,
zfs-modules-@@KVERS@@-dbg,
zfs-headers-@@KVERS@@,
linux-image-@@KVERS@@,
connstat-module-@@KVERS@@
Description: Kernel packages consolidation for the Delphix Appliance.
This package consolidates all the version-specific kernel modules and tools
Expand Down
8 changes: 5 additions & 3 deletions debian/control.azure.in
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,12 +31,14 @@ Standards-Version: 4.1.2
Package: delphix-kernel-@@KVERS@@
Provides: delphix-kernel-azure, delphix-kernel
Architecture: any
Depends: linux-azure,
linux-tools-azure,
Depends: linux-image-@@KVERS@@,
linux-image-@@KVERS@@-dbgsym,
linux-modules-extra-@@KVERS@@,
linux-headers-@@KVERS@@,
linux-tools-@@KVERS@@,
zfs-modules-@@KVERS@@,
zfs-modules-@@KVERS@@-dbg,
zfs-headers-@@KVERS@@,
linux-image-@@KVERS@@,
connstat-module-@@KVERS@@
Description: Kernel packages consolidation for the Delphix Appliance.
This package consolidates all the version-specific kernel modules and tools
Expand Down
8 changes: 5 additions & 3 deletions debian/control.gcp.in
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,12 +31,14 @@ Standards-Version: 4.1.2
Package: delphix-kernel-@@KVERS@@
Provides: delphix-kernel-gcp, delphix-kernel
Architecture: any
Depends: linux-gcp,
linux-tools-gcp,
Depends: linux-image-@@KVERS@@,
linux-image-@@KVERS@@-dbgsym,
linux-modules-extra-@@KVERS@@,
linux-headers-@@KVERS@@,
linux-tools-@@KVERS@@,
zfs-modules-@@KVERS@@,
zfs-modules-@@KVERS@@-dbg,
zfs-headers-@@KVERS@@,
linux-image-@@KVERS@@,
connstat-module-@@KVERS@@
Description: Kernel packages consolidation for the Delphix Appliance.
This package consolidates all the version-specific kernel modules and tools
Expand Down
8 changes: 5 additions & 3 deletions debian/control.generic.in
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,12 +31,14 @@ Standards-Version: 4.1.2
Package: delphix-kernel-@@KVERS@@
Provides: delphix-kernel-generic, delphix-kernel
Architecture: any
Depends: linux-generic-hwe-18.04,
linux-tools-generic-hwe-18.04,
Depends: linux-image-@@KVERS@@,
linux-image-@@KVERS@@-dbgsym,
linux-modules-extra-@@KVERS@@,
linux-headers-@@KVERS@@,
linux-tools-@@KVERS@@,
zfs-modules-@@KVERS@@,
zfs-modules-@@KVERS@@-dbg,
zfs-headers-@@KVERS@@,
linux-image-@@KVERS@@,
connstat-module-@@KVERS@@
Description: Kernel packages consolidation for the Delphix Appliance.
This package consolidates all the version-specific kernel modules and tools
Expand Down
8 changes: 5 additions & 3 deletions debian/control.oracle.in
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,12 +31,14 @@ Standards-Version: 4.1.2
Package: delphix-kernel-@@KVERS@@
Provides: delphix-kernel-oracle, delphix-kernel
Architecture: any
Depends: linux-oracle,
linux-tools-oracle,
Depends: linux-image-@@KVERS@@,
linux-image-@@KVERS@@-dbgsym,
linux-modules-extra-@@KVERS@@,
linux-headers-@@KVERS@@,
linux-tools-@@KVERS@@,
zfs-modules-@@KVERS@@,
zfs-modules-@@KVERS@@-dbg,
zfs-headers-@@KVERS@@,
linux-image-@@KVERS@@,
connstat-module-@@KVERS@@
Description: Kernel packages consolidation for the Delphix Appliance.
This package consolidates all the version-specific kernel modules and tools
Expand Down