Skip to content

Conversation

@pzakha
Copy link
Contributor

@pzakha pzakha commented May 4, 2020

@pzakha pzakha requested review from grwilson, sdimitro and sebroy May 4, 2020 16:30
@sebroy
Copy link

sebroy commented May 4, 2020

Maybe stupid question, but: With the removal of things like linux-aws from the list of dependencies, how does the build bring in the right linux kernel package now?

Architecture: any
Depends: linux-aws,
linux-tools-aws,
Depends: linux-image-@@KVERS@@,
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like with this change, all platform-specific kernel packages share the exact same set of dependencies. Is there a way to consolidate and reduce the duplication?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, we can use a single file instead. I wanted to hold on this for now in case we need to add other packages for some of the platforms, but I can also go ahead with that change if you think it's better to do it now.

@pzakha
Copy link
Contributor Author

pzakha commented May 5, 2020

Maybe stupid question, but: With the removal of things like linux-aws from the list of dependencies, how does the build bring in the right linux kernel package now?

This is done by the Provides line:

Provides: delphix-kernel-aws, delphix-kernel

delphix-platform-aws dependds on delphix-kernel-aws.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants