Auth endpoint #95
Merged
Auth endpoint #95
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… into authEndpoint # Conflicts: # src/main/scala/de/upb/cs/swt/delphi/instanceregistry/Registry.scala # src/main/scala/de/upb/cs/swt/delphi/instanceregistry/connection/Server.scala Also added Dynamic Auth service
johannesduesing
requested changes
Jan 31, 2019
Contributor
johannesduesing
left a comment
johannesduesing
left a comment
There was a problem hiding this comment.
Hey @sami-cseseu, thanks for your PR 👍
I've looked through your code and commented on some design- and some naming-issues below, please change the code accordingly. Also i was wondering about the addUser functionality we discussed last time, because it is not yet part of the code. Please add it for the next review.
src/main/scala/de/upb/cs/swt/delphi/instanceregistry/Configuration.scala
Outdated
Show resolved
Hide resolved
src/main/scala/de/upb/cs/swt/delphi/instanceregistry/Registry.scala
Outdated
Show resolved
Hide resolved
src/main/scala/de/upb/cs/swt/delphi/instanceregistry/authorization/AuthProvider.scala
Outdated
Show resolved
Hide resolved
src/main/scala/de/upb/cs/swt/delphi/instanceregistry/authorization/AuthProvider.scala
Outdated
Show resolved
Hide resolved
src/main/scala/de/upb/cs/swt/delphi/instanceregistry/authorization/AuthProvider.scala
Outdated
Show resolved
Hide resolved
src/main/scala/de/upb/cs/swt/delphi/instanceregistry/authorization/AuthProvider.scala
Outdated
Show resolved
Hide resolved
src/main/scala/de/upb/cs/swt/delphi/instanceregistry/daos/DatabaseAuthDAO.scala
Outdated
Show resolved
Hide resolved
src/main/scala/de/upb/cs/swt/delphi/instanceregistry/daos/DynamicAuthDAO.scala
Outdated
Show resolved
Hide resolved
...scala/de/upb/cs/swt/delphi/instanceregistry/io/swagger/client/model/RequestJsonSupport.scala
Outdated
Show resolved
Hide resolved
...scala/de/upb/cs/swt/delphi/instanceregistry/io/swagger/client/model/RequestJsonSupport.scala
Outdated
Show resolved
Hide resolved
johannesduesing
approved these changes
Feb 3, 2019
Contributor
johannesduesing
left a comment
johannesduesing
left a comment
There was a problem hiding this comment.
Great work @sami-cseseu, tested it using both in-memory and SQL-DB, and it worked like expected. Good job 👍
This was referenced Feb 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added authentication endpoint by using it user will get authentication token for request