Skip to content

Renamed docker host environment variable #88

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 20, 2019
Merged

Renamed docker host environment variable #88

merged 1 commit into from
Jan 20, 2019

Conversation

@johannesduesing
Copy link
Contributor

@johannesduesing johannesduesing commented Jan 20, 2019

Reason for this PR
While testing the registry setup for OSX we found that the environment variable name we use to define the docker host URL (DOCKER_HOST) is used by other applications as well and causes name-clashes. See #83 for more information.

Changes in this PR

  • Changed the environment variable name from DOCKER_HOST to DELPHI_DOCKER_HOST.

@johannesduesing johannesduesing added the bug Something isn't working label Jan 20, 2019
@johannesduesing johannesduesing added this to the v0.9.0 milestone Jan 20, 2019
@johannesduesing johannesduesing self-assigned this Jan 20, 2019
@24santoshr 24santoshr merged commit 1d3812f into develop Jan 20, 2019
@24santoshr 24santoshr deleted the bugfix/dockerEnvVarName branch January 20, 2019 16:57
@johannesduesing johannesduesing mentioned this pull request Jan 20, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@24santoshr 24santoshr 24santoshr approved these changes

Assignees

@johannesduesing johannesduesing

Labels

bug Something isn't working

Projects

None yet

Milestone

v0.9.0

Development

Successfully merging this pull request may close these issues.

3 participants

@johannesduesing @24santoshr