Skip to content
This repository was archived by the owner on Mar 24, 2025. It is now read-only.

Conversation

@srowen
Copy link
Collaborator

@srowen srowen commented Dec 19, 2018

This should supersede:

To make the fix, it seemed necessary to rewrite the logic in terms of characters, not bytes. Honestly I don't know why the original implementation worked in terms of bytes, even though I might have been part of it.

This does handle self-closing tags, but not nested copies of the same row tag. The latter is either something we need to drop or, will require another rewrite to handle sanely.

@srowen srowen added the bug label Dec 19, 2018
@srowen srowen added this to the 0.5.0 milestone Dec 19, 2018
@srowen srowen self-assigned this Dec 19, 2018
@srowen srowen requested a review from HyukjinKwon December 19, 2018 22:51
@codecov-io
Copy link

codecov-io commented Dec 19, 2018

Codecov Report

Merging #352 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #352   +/-   ##
=====================================
  Coverage       0%     0%           
=====================================
  Files          14     14           
  Lines         737    728    -9     
  Branches       57     66    +9     
=====================================
+ Misses        737    728    -9
Impacted Files Coverage Δ
...cala/com/databricks/spark/xml/XmlInputFormat.scala 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f7db55a...9701345. Read the comment docs.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants