This repository was archived by the owner on Mar 24, 2025. It is now read-only.
Rewrite XMLInputFormat in terms of chars not bytes. Fix handling of self-closing tags #352
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should supersede:
To make the fix, it seemed necessary to rewrite the logic in terms of characters, not bytes. Honestly I don't know why the original implementation worked in terms of bytes, even though I might have been part of it.
This does handle self-closing tags, but not nested copies of the same row tag. The latter is either something we need to drop or, will require another rewrite to handle sanely.