This repository was archived by the owner on Mar 24, 2025. It is now read-only.
Add test case for self-closing tag inside row #316
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@BioQwer, would you mind if I ask to take a look please? I think we should revert the commit to keep the compatibility. |
HyukjinKwon
reviewed
Jul 10, 2018
Member
HyukjinKwon
left a comment
HyukjinKwon
left a comment
There was a problem hiding this comment.
@gerbszt, thanks for adding this test. It will be merged as is after reverting the commit, or another fix will be open with the proposed test here.
Contributor
|
Yes, I will see it. |
Member
|
Let me revert that one and make a release within few weeks as it's really been a while since the last release. |
Contributor
|
@HyukjinKwon I'm sorry for the delay. |
Collaborator
|
This should be fixed by #352 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The latest commit to master branch introduced a small bug - rows with self-closing tags inside cannot be parsed anymore.
XmlInputFormat stops reading the row once it encounters '/>' sequence. It was meant to be one of the possible endings of row, but it may happen inside it as well.
This PR doesn't solve the problem, but makes it easy to spot by providing a simple test case.
Previous master's HEAD (prior the commit in question) passes the test, so maybe the best approach would be to revert f3772 commit, apply this PR and merge f3772 back once it passes updated test suite.