Skip to content

fix no-op hot restarts #311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 22, 2019
Merged

fix no-op hot restarts #311

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
69f4ae0
fix no-op hot restarts to actually do a restart still
jakemac53 Apr 19, 2019
f87e0b3
spelling mistake
jakemac53 Apr 22, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 18 additions & 5 deletions webdev/lib/src/serve/debugger/webdev_vm_client.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,11 +37,24 @@ class WebdevVmClient {
.add(jsonDecode(request) as Map<String, dynamic>));
client.registerServiceCallback('hotRestart', (request) async {
debugService.chromeProxyService.destroyIsolate();
await debugService.chromeProxyService.tabConnection.runtime.sendCommand(
'Runtime.evaluate',
params: {'expression': r'$dartHotRestart();', 'awaitPromise': true});
unawaited(debugService.chromeProxyService.createIsolate());
return {'result': Success().toJson()};
var response = await debugService.chromeProxyService.tabConnection.runtime
.sendCommand('Runtime.evaluate', params: {
'expression': r'$dartHotRestart();',
'awaitPromise': true
});
var exceptionDetails = response.result['exceptionDetails'];
if (exceptionDetails != null) {
return {
'error': {
'code': -32603,
'message': exceptionDetails['exception']['description'],
'data': exceptionDetails,
}
};
} else {
unawaited(debugService.chromeProxyService.createIsolate());
return {'result': Success().toJson()};
}
});
await client.registerService('hotRestart', 'WebDev');

Expand Down
Loading