fix no-op hot restarts #311
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
This might potentially fix #293 as well (if it was due to a race condition) |
Contributor
Author
|
@nshahan if you could try and verify that would be great :) |
grouma
reviewed
Apr 19, 2019
webdev/web/promise.dart
Outdated
| } | ||
|
|
||
| /// Returns a Future that resolves once the given [promise] resolves. | ||
| /// Returns a [Promise] that resolves once the give [future] resolves. |
grouma
approved these changes
Apr 19, 2019
Contributor
|
@jakemac53 LGTM. It fixes the issue with the app disappearing after manually triggering a hot restart without any changes. |
This was referenced Apr 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #302
Previously the behavior was pretty broken, after talking with @jacob314 we decided the best thing to do is actually restart the app (even if it doesn't have anything new to load).
I also did some other cleanup to make things more robust:
$dartHotRestartcall so that it can be properly awaited (we weren't actually waiting before because it was a dart future, so this may have contributed to race conditions).$dartHotRestartcall.