Fix mixtures of parentheses and spaces in windows command paths

[jakemac53]

Should resolve #2137.

Dropped the sanitizeExecutablePath entirely as it no longer seems to be necessary (SDK issue was closed long ago)

[jakemac53]

cc @DanTup

[github-actions]

PR Health

Breaking changes ✔️

Package	Change	Current Version	New Version	Needed Version	Looking good?
process	None	5.0.4	5.0.5	5.0.4	✔️

Changelog Entry ✔️

Package	Changed Files

Changes to files need to be accounted for in their respective changelogs.

Coverage ✔️

File	Coverage
pkgs/process/lib/src/interface/common.dart	💚 100 %
pkgs/process/lib/src/interface/local_process_manager.dart	💚 40 % ⬆️ Infinity %

This check for test coverage is informational (issues shown here will not fail the PR).

API leaks ✔️

The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.

Package	Leaked API symbols

License Headers ✔️

// Copyright (c) 2025, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.

Files
no missing headers

All source files should start with a license header.

Unrelated files missing license headers

Files
pkgs/bazel_worker/benchmark/benchmark.dart
pkgs/bazel_worker/example/client.dart
pkgs/bazel_worker/example/worker.dart
pkgs/benchmark_harness/integration_test/perf_benchmark_test.dart
pkgs/boolean_selector/example/example.dart
pkgs/clock/lib/clock.dart
pkgs/clock/lib/src/clock.dart
pkgs/clock/lib/src/default.dart
pkgs/clock/lib/src/stopwatch.dart
pkgs/clock/lib/src/utils.dart
pkgs/clock/test/clock_test.dart
pkgs/clock/test/default_test.dart
pkgs/clock/test/stopwatch_test.dart
pkgs/clock/test/utils.dart
pkgs/coverage/lib/src/coverage_options.dart
pkgs/html/example/main.dart
pkgs/html/lib/dom.dart
pkgs/html/lib/dom_parsing.dart
pkgs/html/lib/html_escape.dart
pkgs/html/lib/parser.dart
pkgs/html/lib/src/constants.dart
pkgs/html/lib/src/encoding_parser.dart
pkgs/html/lib/src/html_input_stream.dart
pkgs/html/lib/src/list_proxy.dart
pkgs/html/lib/src/query_selector.dart
pkgs/html/lib/src/token.dart
pkgs/html/lib/src/tokenizer.dart
pkgs/html/lib/src/treebuilder.dart
pkgs/html/lib/src/utils.dart
pkgs/html/test/dom_test.dart
pkgs/html/test/parser_feature_test.dart
pkgs/html/test/parser_test.dart
pkgs/html/test/query_selector_test.dart
pkgs/html/test/selectors/level1_baseline_test.dart
pkgs/html/test/selectors/level1_lib.dart
pkgs/html/test/selectors/selectors.dart
pkgs/html/test/support.dart
pkgs/html/test/tokenizer_test.dart
pkgs/html/test/trie_test.dart
pkgs/html/tool/generate_trie.dart
pkgs/pubspec_parse/test/git_uri_test.dart
pkgs/stack_trace/example/example.dart
pkgs/watcher/test/custom_watcher_factory_test.dart
pkgs/yaml_edit/example/example.dart

[github-actions]

Package publishing

Package	Version	Status	Publish tag (post-merge)
package:bazel_worker	1.1.3	already published at pub.dev
package:benchmark_harness	2.4.0-wip	WIP (no publish necessary)
package:boolean_selector	2.1.2	already published at pub.dev
package:browser_launcher	1.1.3	already published at pub.dev
package:cli_config	0.2.1-wip	WIP (no publish necessary)
package:cli_util	0.5.0-wip	WIP (no publish necessary)
package:clock	1.1.3-wip	WIP (no publish necessary)
package:code_builder	4.10.2-wip	WIP (no publish necessary)
package:coverage	1.15.0	already published at pub.dev
package:csslib	1.0.2	already published at pub.dev
package:extension_discovery	2.1.0	already published at pub.dev
package:file	7.0.2-wip	WIP (no publish necessary)
package:file_testing	3.1.0-wip	WIP (no publish necessary)
package:glob	2.1.3	already published at pub.dev
package:graphs	2.3.3-wip	WIP (no publish necessary)
package:html	0.15.6	already published at pub.dev
package:io	1.1.0-wip	WIP (no publish necessary)
package:json_rpc_2	4.0.0	already published at pub.dev
package:markdown	7.3.1-wip	WIP (no publish necessary)
package:mime	2.0.0	already published at pub.dev
package:oauth2	2.0.4-wip	WIP (no publish necessary)
package:package_config	2.3.0-wip	WIP (no publish necessary)
package:pool	1.5.2-wip	WIP (no publish necessary)
package:process	5.0.5	ready to publish	process-v5.0.5
package:pub_semver	2.2.0	already published at pub.dev
package:pubspec_parse	1.5.0	already published at pub.dev
package:source_map_stack_trace	2.1.3-wip	WIP (no publish necessary)
package:source_maps	0.10.14-wip	WIP (no publish necessary)
package:source_span	1.10.1	already published at pub.dev
package:sse	4.1.8	already published at pub.dev
package:stack_trace	1.12.1	already published at pub.dev
package:stream_channel	2.1.4	already published at pub.dev
package:stream_transform	2.1.2-wip	WIP (no publish necessary)
package:string_scanner	1.4.1	already published at pub.dev
package:term_glyph	1.2.3-wip	WIP (no publish necessary)
package:test_reflective_loader	0.3.0	already published at pub.dev
package:timing	1.0.2	already published at pub.dev
package:unified_analytics	8.0.5	already published at pub.dev
package:watcher	1.1.2	already published at pub.dev
package:yaml	3.1.3	already published at pub.dev
package:yaml_edit	2.2.2	already published at pub.dev

Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation.

[jakemac53]

Weird, I cannot replicate the originally reported error without this patch - the integration test I added at the end works either way.

[jakemac53]

Ahhh, so I can replicate this error with runInShell: true.

[DanTup]

@jakemac53 for my original issue, the folder was named "Latest (Bleeding Edge)" which contains both spaces and quotes, so I would've expected it to already be quoted (in fact in the screenshot, it looks wrapped in quotes). Might there be more to it?

I can do some testing locally tomorrow and see if I can confirm if this fixes it (and if not, try to figure out why).

[DanTup]

Oh, this sounded familiar and I found this in Dart-Code:

	// Spawning processes on Windows with funny symbols in the path requires quoting. However if you quote an
	// executable with a space in its path and an argument also has a space, you have to then quote _all_ of the
	// arguments!
	// https://github.com/nodejs/node/issues/7367

https://github.com/Dart-Code/Dart-Code/blob/7f51d4c35f48b0bb69f7913aaa94e6b501e403f4/src/shared/processes.ts#L30-L33

Shell execute is a mess. If you know you're getting dart.exe (and not the dart shell script from Flutter's bin folder), I wonder if you should skip shell execute instead? In Dart-Code we now only use the shell if the target ends with .bat:

https://github.com/Dart-Code/Dart-Code/blob/7f51d4c35f48b0bb69f7913aaa94e6b501e403f4/src/shared/processes.ts#L19

[jakemac53]

When testing locally on windows it seems like the dart issue has since been closed and now this helper code is actually causing problems when parentheses are involved.

I have now removed the helper and its tests, and added integration tests that actually run an executable, and also added windows testing to the GitHub workflows for this package.

[jakemac53]

Ok, so actually it looks like when there are only parenthesis this still doesn't work. However, simply wrapping it in quotes also doesn't work.

I don't know what the right thing to do here is.

[jakemac53]

Shell execute is a mess. If you know you're getting dart.exe (and not the dart shell script from Flutter's bin folder), I wonder if you should skip shell execute instead? In Dart-Code we now only use the shell if the target ends with .bat:

I can try this, but dang does that sound hacky lol.

[DanTup]

Shell execute is a mess. If you know you're getting dart.exe (and not the dart shell script from Flutter's bin folder), I wonder if you should skip shell execute instead? In Dart-Code we now only use the shell if the target ends with .bat:

I can try this, but dang does that sound hacky lol.

Perhaps, but escape correctly for shell is already a minefield (see dart-lang/sdk#59604 for some issues that were never resolved). If you know you're executing a binary and don't need the shell, avoiding it makes things simpler.

I'll see if I can pull these changes in locally and test my original problem and post back.

[DanTup]

I pulled these changes locally and tested with my original issue, and the tests ran successfully (where my SDK has both spaces and parens, and my test project has spaces):

[jakemac53]

I restarted the windows jobs to see if they get picked up... if not I guess I will remove them as they don't ever seem to run 😭

Looks like it was just a bad OS name and GitHub likes to waste time queueing jobs for oses that don't exist :P

[jakemac53]

Btw I skipped the test for having just parenthesis in the path and filed a separate issue. This is not a regression, its a new test that is failing (there was no special handling for this case before).