-
Notifications
You must be signed in to change notification settings - Fork 43
add --exclude-tool option to exclude tools by name #253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
PR HealthChangelog Entry ✔️
Changes to files need to be accounted for in their respective changelogs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm :-)
..addMultiOption( | ||
excludeToolOption, | ||
help: 'The names of tools to exclude from this run of the server.', | ||
); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It might be useful to include a list of the tools, or have a list-tools
command to make it easier to get the exact identifiers that should be used here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That one is a bit harder to do accurately because we might start wanting to have the list of tools change over time... for instance not show flutter_driver as a tool until an app with flutter_driver enabled is actually attached.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just meant a full list of possible tools.
I noticed in VS Code that the tool names shown in the UI don't match what the LLM things they are (for example in the VS Code UI it says that the built-in tool is called runTests
and Dart's is run_tests
, but if I ask the model what tools it has, they are both called run_tests
). So mostly I was just after a way to ensure I can get a list of the IDs that are definitely the right ones to pass to this flag.
(grabbing it out of the source code works too, but printing them would make it harder for me to use the wrong values if there are names + ids or something).
…, web, webdriver Revisions updated by `dart tools/rev_sdk_deps.dart`. ai (https://github.com/dart-lang/ai/compare/7fbe88a..72a9283): 72a9283 2025-07-31 Jacob MacDonald add --exclude-tool option to exclude tools by name (dart-lang/ai#253) 0dbbd8b 2025-07-30 Jacob MacDonald only run in shell when on windows and running a .bat file (dart-lang/ai#252) 0858b0b 2025-07-28 Jacob MacDonald further prompt refinement, discourage use of temp ids and encourage getting the widget tree often (dart-lang/ai#249) 912c1f3 2025-07-28 Jacob MacDonald release dart_mcp v0.3.3 (dart-lang/ai#247) 0f7cba8 2025-07-28 Jacob MacDonald add analytics tracking for prompts (dart-lang/ai#246) dartdoc (https://github.com/dart-lang/dartdoc/compare/882aea9..414953e): 414953ed 2025-08-04 Sam Rawlins Simplify how inheritance is computed. (dart-lang/dartdoc#4079) ecosystem (https://github.com/dart-lang/ecosystem/compare/d5233c6..2fe3618): 2fe3618 2025-08-01 dependabot[bot] Bump the github-actions group with 3 updates (dart-lang/ecosystem#361) protobuf (https://github.com/dart-lang/protobuf/compare/44ecd74..0b73b0d): 0b73b0d 2025-07-30 Devon Carew workspace, formatting, and proto version updates (google/protobuf.dart#1033) a664760 2025-07-30 Devon Carew various CI workflow updates (google/protobuf.dart#1035) test (https://github.com/dart-lang/test/compare/6aeb1e4..953e828): 953e8282 2025-08-01 Nate Bosch Drop executable arguments forwarding (dart-lang/test#2528) tools (https://github.com/dart-lang/tools/compare/2a2a2d6..5e977d6): 5e977d6f 2025-07-30 Jacob MacDonald Fix mixtures of parentheses and spaces in windows command paths (dart-lang/tools#2138) 607340ca 2025-07-29 Devon Carew disable failing test (dart-lang/tools#2136) vector_math (https://github.com/google/vector_math.dart/compare/13f185f..3939545): 3939545 2025-08-04 Kevin Moore Bump min SDK to 3.7, update dependencies, reformat (google/vector_math.dart#348) web (https://github.com/dart-lang/web/compare/da1dd5d..1d5771b): 1d5771b 2025-07-31 Nikechukwu [interop] Add support for importing and exporting declarations, as well as multi-file output (dart-lang/web#418) webdriver (https://github.com/google/webdriver.dart/compare/cfab787..595649d): 595649d 2025-08-01 dependabot[bot] Bump nanasess/setup-chromedriver (google/webdriver.dart#331) Change-Id: Ia014bf6cafa9edcdaf453edda9cd5ecff516e16d Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/443625 Auto-Submit: Devon Carew <[email protected]> Reviewed-by: Konstantin Shcheglov <[email protected]> Commit-Queue: Konstantin Shcheglov <[email protected]>
Closes #251
cc @DanTup