Skip to content

Remove unused href field from error report #2061

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 12 commits into from
Closed

Remove unused href field from error report #2061

Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
51ffe61
Overhaul the channel between host and iframes
natebosch Jul 6, 2023
e52b17c
dartfmt
natebosch Jul 7, 2023
7c0b899
Merge branch 'master' into single-message-on-outer-channel
natebosch Jul 19, 2023
d608e4a
Missed merge markers
natebosch Jul 19, 2023
f8a867a
Merge branch 'master' into single-message-on-outer-channel
natebosch Jul 19, 2023
397b2ad
dart format
natebosch Jul 19, 2023
3e04c7b
Use a switch
natebosch Jul 20, 2023
75783fe
Update comments
natebosch Jul 20, 2023
f0b966a
Merge branch 'master' into single-message-on-outer-channel
natebosch Jul 31, 2023
ded6714
Merge branch 'master' into single-message-on-outer-channel
natebosch Aug 11, 2023
1db0de4
Remove support for old pattern
natebosch Aug 11, 2023
55fb948
Merge branch 'master' into single-message-on-outer-channel
natebosch Oct 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions pkgs/test/lib/dart.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,6 @@ window.onload = function() {
// This mimics a MultiChannel-formatted message.
var sendLoadException = function(message) {
window.parent.postMessage({
// TODO: https://github.com/dart-lang/test/issues/2065 - remove href
"href": window.location.href,
"data": [0, {"type": "loadException", "message": message}],
"exception": true,
}, window.location.origin);
Expand Down