Remove unused href field from error report #2061
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Originally all communication was done through `postMessage` on the `window`, but the manual checking between the `iframe.src` and the iframe's `window.location.href` could go out of sync if the code under test changed the browser location. To maintain the connection an isolated `MessageChannel` was created for each frame, and only the port for the channel was communicated across the window where the `href` would need to be checked, but it was passed from the host to the frame so the `origin` and `href` comparison was repeated on both sides. Move the channel creation to the frame and send the port in place of the old `'ready'` message. The ambiguous window level messages are now only sent one direction, and only once. Immediately remove the window level event listener for the individual frame once it has established the channel (or reported an exception while loading). Drop the `readyCompleter` and avoid subscribing to the channel local stream until the iframe is ready and has sent a `MessagePort`. Read the source from the message instead of sending the href in the body. The linked issue (dart-lang/sdk#22554) is only a problem when using `dart:html` which we no longer use. Since not all message source types have a `location.href` property, use `js_util.getProperty` which will return `null` when it is missing which may be the case if some other source posts a message to the window (which is not expected). Drop the extra `_postParentMessage` definition, it became redundant when migrating the other DOM interaction to static interop instead of `dart:html`.
natebosch
commented
Jul 7, 2023
Member
Author
|
Flutter has an old copy of this code. If we make this change, when we roll |
Member
Author
|
This host <-> frame communication has been copied or reimplemented in a few places. Internal google code has a separate host implementations, and I cannot land the change in flutter until the package is published to pub. I will not publish a change like this to pub until we have internal validation. To resolve the deadlock I'm going to take a try at first implementing a backwards/forwards compatible |
9 tasks
natebosch
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally the href was added manually to the data to work around a
dart:htmllimitation. A different workaround for the host side wasimplemented in #2066, but the frame side was not changed in the same
commit to allow some cross-compatibility. Remove the final manual href
field now that no host implementations would read it.