linter 1.32.0 plan

[pq]

1.32.0

• update avoid_types_as_parameter_names to handle type variables
• update avoid_positional_boolean_parameters to handle typedefs
• improve unnecessary_parenthesis support for property accesses and method invocations
• update avoid_redundant_argument_values to check parameters of redirecting constructors
• performance improvements for prefer_const_literals_to_create_immutables
• update use_build_context_synchronously to check context properties
• fix false positive for avoid_private_typedef_functions with generalized type aliases

---

release testing

Try: https://dart-review.googlesource.com/c/sdk/+/275044

downstream fixes

• fix new avoid_redundant_argument_values diagnostics in flutter
  • (https://logs.chromium.org/logs/dart/buildbucket/cr-buildbucket/8797403260884127729/+/u/analyze_flutter_flutter/stdout)
• fix new unnecessary_parenthesis diagnostics in the SDK (https://dart-review.googlesource.com/c/sdk/+/275044)
• fix new unnecessary_parenthesis diagnostics in flutter
  • Fix new unnecessary_parenthesis diagnostics. flutter/flutter#117081
  • fix false positive with nullable property accesses (🍻 @asashour -- Fix unnecessary_parenthesis with null aware expressions. dart-archive/linter#3902)
  • fix false positive with a postfix ! (🎉 @asashour -- Fix unnecessary_parenthesis with postfix bang operator. dart-archive/linter#3904)
• fix new unnecessary_parenthesis diagnostics in flutter plugins
  • [camera_android_camerax] unnecessary_parenthesis lint fix flutter/plugins#6841
• fix new unnecessary_parenthesis diagnostics in flutter engine
  • Fix new unnecessary_parenthesis diagnostics. flutter/engine#38291

---

/fyi @srawlins

[asashour]

The link is private, I guess it should better be the public https://dart-review.googlesource.com/c/sdk/+/269747

(there were other places where the the dart-review SDK link didn't contain googlesource, but this probably seems important).

[pq]

Thanks for catching this!

[pq]

Reviving this as 1.31.0 has landed and will (soon 🤞) be cherry-picked to beta.

I'll update the issue description with a changelog. There's a lot queued up so I expect this could be a pretty fun one to land (but good to do before we start on some plumbing for removals, etc (#3880)). 🥳

/fyi @srawlins @bwilkerson @oprypin

[pq]

Here's an interesting unnecessary_parenthesis diagnostic:

^ (pingSuccessRegex?.pattern).hashCode

https://github.com/flutter/flutter/blob/master/packages/flutter_tools/lib/src/custom_devices/custom_device_config.dart#L553

(and also 559).

See:

https://logs.chromium.org/logs/dart/buildbucket/cr-buildbucket/8794947421050841633/+/u/analyze_flutter_flutter/stdout

/cc @asashour /fyi @srawlins

[pq]

Thanks for the quick fix @asashour! I've pulled in that change and have kicked off another try-run (cl/275044).