Skip to content
This repository was archived by the owner on Nov 20, 2024. It is now read-only.

Conversation

@pq
Copy link
Contributor

@pq pq commented Dec 14, 2022

1.32.0

  • update avoid_types_as_parameter_names to handle type variables
  • update avoid_positional_boolean_parameters to handle typedefs
  • improve unnecessary_parenthesis support for property accesses and method invocations
  • update avoid_redundant_argument_values to check parameters of redirecting constructors
  • performance improvements for prefer_const_literals_to_create_immutables
  • update use_build_context_synchronously to check context properties
  • fix false positive for avoid_private_typedef_functions with generalized type aliases

Closes: dart-lang/sdk#58928

RC being tested on https://dart-review.googlesource.com/c/sdk/+/275044.

/cc @bwilkerson @srawlins

@coveralls
Copy link

Coverage Status

Coverage remained the same at 95.637% when pulling 7380221 on linter_132 into b4c66e8 on main.

@pq pq merged commit 79b8433 into main Dec 15, 2022
@pq pq deleted the linter_132 branch December 15, 2022 17:50
@@ -1,8 +1,18 @@
# 1.32.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI - as a drive by comment - it looks like 1.31.0 has not been published; the latest published version is 1.30.0.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pq has been experimenting not publishing linter, as there is no known use case for publishing it.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, that makes a certain amount if sense :)

Perhaps change the listing on pub.dev to 'unlisted'? That'll mean it won't show up in search results.

If we know were never going to publish it again (which it sounds like we're not yet certain of?) it can instead be marked 'discontinued' in pub.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unlisted is an interesting option. We've got a few dependent packages so we'll want to sort that out before we go too far. Maybe we can discuss in person?

copybara-service bot pushed a commit to dart-lang/sdk that referenced this pull request Aug 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Development

Successfully merging this pull request may close these issues.

linter 1.32.0 plan

6 participants