-
Notifications
You must be signed in to change notification settings - Fork 224
Use camelCase on properties #1470
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Matheus Cruz <[email protected]>
@salaboy I added as camelCase to support both (spring support camelCase too), WDYT? |
@mcruzdev, thanks for the change, but it will be great if we can add some tests to see if these and the previous ones that you documented both work for the spring boot application.properties. I have the feeling that there are a couple of approaches implemented for different situations, and I am not sure if they are covered by tests. For example if you are using: |
Signed-off-by: Matheus Cruz <[email protected]>
1dbd120
to
8febfa8
Compare
Hi @salaboy we already have a test for it (using |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mcruzdev could you please take a look and let me know if we can merge this. |
Co-authored-by: Cassie Coyle <[email protected]> Signed-off-by: Matheus Cruz <[email protected]>
Sorry @cicoyle and @artur-ciocanu for delay. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1470 +/- ##
============================================
+ Coverage 76.91% 78.73% +1.81%
- Complexity 1592 1918 +326
============================================
Files 145 237 +92
Lines 4843 5924 +1081
Branches 562 610 +48
============================================
+ Hits 3725 4664 +939
- Misses 821 938 +117
- Partials 297 322 +25 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
* Use camelCase on properties Signed-off-by: Matheus Cruz <[email protected]> * Add test for cameCalse properties Signed-off-by: Matheus Cruz <[email protected]> * Update daprdocs/content/en/java-sdk-docs/spring-boot/_index.md Co-authored-by: Cassie Coyle <[email protected]> Signed-off-by: Matheus Cruz <[email protected]> --------- Signed-off-by: Matheus Cruz <[email protected]> Signed-off-by: Matheus Cruz <[email protected]> Co-authored-by: artur-ciocanu <[email protected]> Co-authored-by: Cassie Coyle <[email protected]>
* Use camelCase on properties Signed-off-by: Matheus Cruz <[email protected]> * Add test for cameCalse properties Signed-off-by: Matheus Cruz <[email protected]> * Update daprdocs/content/en/java-sdk-docs/spring-boot/_index.md Co-authored-by: Cassie Coyle <[email protected]> Signed-off-by: Matheus Cruz <[email protected]> --------- Signed-off-by: Matheus Cruz <[email protected]> Signed-off-by: Matheus Cruz <[email protected]> Co-authored-by: artur-ciocanu <[email protected]> Co-authored-by: Cassie Coyle <[email protected]> Signed-off-by: Javier Aliaga <[email protected]>
* Use camelCase on properties Signed-off-by: Matheus Cruz <[email protected]> * Add test for cameCalse properties Signed-off-by: Matheus Cruz <[email protected]> * Update daprdocs/content/en/java-sdk-docs/spring-boot/_index.md Co-authored-by: Cassie Coyle <[email protected]> Signed-off-by: Matheus Cruz <[email protected]> --------- Signed-off-by: Matheus Cruz <[email protected]> Signed-off-by: Matheus Cruz <[email protected]> Co-authored-by: artur-ciocanu <[email protected]> Co-authored-by: Cassie Coyle <[email protected]> Signed-off-by: Javier Aliaga <[email protected]>
* process deps too for dapr-spring (#1503) Signed-off-by: Cassandra Coyle <[email protected]> Signed-off-by: Javier Aliaga <[email protected]> * Use camelCase on properties (#1470) * Use camelCase on properties Signed-off-by: Matheus Cruz <[email protected]> * Add test for cameCalse properties Signed-off-by: Matheus Cruz <[email protected]> * Update daprdocs/content/en/java-sdk-docs/spring-boot/_index.md Co-authored-by: Cassie Coyle <[email protected]> Signed-off-by: Matheus Cruz <[email protected]> --------- Signed-off-by: Matheus Cruz <[email protected]> Signed-off-by: Matheus Cruz <[email protected]> Co-authored-by: artur-ciocanu <[email protected]> Co-authored-by: Cassie Coyle <[email protected]> Signed-off-by: Javier Aliaga <[email protected]> * fix script (#1506) Signed-off-by: Cassandra Coyle <[email protected]> Signed-off-by: Javier Aliaga <[email protected]> * add support for custom status (#1505) Signed-off-by: salaboy <[email protected]> Co-authored-by: Siri Varma Vegiraju <[email protected]> Signed-off-by: Javier Aliaga <[email protected]> * try 1.5.7 (#1487) Signed-off-by: Cassandra Coyle <[email protected]> Co-authored-by: Siri Varma Vegiraju <[email protected]> Co-authored-by: artur-ciocanu <[email protected]> Co-authored-by: Dapr Bot <[email protected]> Signed-off-by: Javier Aliaga <[email protected]> * rm protoc cmd from pom.xml (#1498) * rm protoc cmd bc it uses a local protoc which might be the wrong version and results in a bad error Signed-off-by: Cassandra Coyle <[email protected]> * update protoc Signed-off-by: Cassandra Coyle <[email protected]> --------- Signed-off-by: Cassandra Coyle <[email protected]> Co-authored-by: artur-ciocanu <[email protected]> Co-authored-by: salaboy <[email protected]> Signed-off-by: Javier Aliaga <[email protected]> * feat: Support registering activities with custom name (#1431) * feat: Support register of activities with custom name Signed-off-by: Javier Aliaga <[email protected]> * chore: Apply suggestions Signed-off-by: Javier Aliaga <[email protected]> --------- Signed-off-by: Javier Aliaga <[email protected]> Co-authored-by: Cassie Coyle <[email protected]> Co-authored-by: Dapr Bot <[email protected]> Signed-off-by: Javier Aliaga <[email protected]> * Bump codecov/codecov-action from 5.4.3 to 5.5.0 (#1513) Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action) from 5.4.3 to 5.5.0. - [Release notes](https://github.com/codecov/codecov-action/releases) - [Changelog](https://github.com/codecov/codecov-action/blob/main/CHANGELOG.md) - [Commits](codecov/codecov-action@v5.4.3...v5.5.0) --- updated-dependencies: - dependency-name: codecov/codecov-action dependency-version: 5.5.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Cassie Coyle <[email protected]> Co-authored-by: Dapr Bot <[email protected]> Signed-off-by: Javier Aliaga <[email protected]> * commit: Fix validate job (#1524) Signed-off-by: Javier Aliaga <[email protected]> * chore: New task execution task id test (#1352) (#1526) * chore: New task execution task id test test how taskExecutionTaskId can be used for idempotency * chore: Clean up not used files * docs: Task execution keys * test: Modify unit tests * Remove new lines --------- Signed-off-by: Javier Aliaga <[email protected]> Signed-off-by: artur-ciocanu <[email protected]> Co-authored-by: Cassie Coyle <[email protected]> Co-authored-by: artur-ciocanu <[email protected]> Signed-off-by: Javier Aliaga <[email protected]> * Bump actions/checkout from 4 to 5 (#1504) Bumps [actions/checkout](https://github.com/actions/checkout) from 4 to 5. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v4...v5) --- updated-dependencies: - dependency-name: actions/checkout dependency-version: '5' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Siri Varma Vegiraju <[email protected]> Co-authored-by: Dapr Bot <[email protected]> Co-authored-by: Cassie Coyle <[email protected]> Signed-off-by: Javier Aliaga <[email protected]> * Improve CI runs (#1527) * chore: Wait for dapr script When running mechanical markdown examples wait for dapr to be running Signed-off-by: Javier Aliaga <[email protected]> * chore: Fix build ci Signed-off-by: Javier Aliaga <[email protected]> * chore: Fix build ci Signed-off-by: Javier Aliaga <[email protected]> --------- Signed-off-by: Javier Aliaga <[email protected]> Co-authored-by: salaboy <[email protected]> Signed-off-by: Javier Aliaga <[email protected]> * Fix CVEs (#1529) * chore: Read test certs from resources folder This will avoid importing bouncy castle library just for tests Signed-off-by: Javier Aliaga <[email protected]> * ci: Split unit test and integration tests Signed-off-by: Javier Aliaga <[email protected]> --------- Signed-off-by: Javier Aliaga <[email protected]> * fix: Use correct snapshot url (#1530) Signed-off-by: Javier Aliaga <[email protected]> * Bump actions/setup-java from 4 to 5 (#1512) Signed-off-by: Javier Aliaga <[email protected]> * chore: Bump dapr version (#1539) * chore: Bump dapr version Signed-off-by: Javier Aliaga <[email protected]> * chore: Fix conversation tests Only one response expected Signed-off-by: Javier Aliaga <[email protected]> --------- Signed-off-by: Javier Aliaga <[email protected]> * Adding logger to WorkflowActivityContext (#1534) * Adding logger to WorkflowActivityContext Signed-off-by: Artur Ciocanu <[email protected]> * Fixing a styling issue Signed-off-by: Artur Ciocanu <[email protected]> * Add unit tests for workflow activity context Signed-off-by: Artur Ciocanu <[email protected]> * Add more unit tests to make Codecov happy Signed-off-by: Artur Ciocanu <[email protected]> * Add more unit tests Signed-off-by: Artur Ciocanu <[email protected]> * Improve code coverage Signed-off-by: Artur Ciocanu <[email protected]> * Improve test names Signed-off-by: Artur Ciocanu <[email protected]> --------- Signed-off-by: Artur Ciocanu <[email protected]> Co-authored-by: Artur Ciocanu <[email protected]> Co-authored-by: salaboy <[email protected]> Signed-off-by: Javier Aliaga <[email protected]> * Use notimestamp in Javadoc Plugin to disable timestamps in Javadocs (#1538) Signed-off-by: Javier Aliaga <[email protected]> * Feat Cross App CallActivity (#1468) * cross app ex Signed-off-by: Cassandra Coyle <[email protected]> * update protoc cmd Signed-off-by: Cassandra Coyle <[email protected]> * feedback Signed-off-by: Cassandra Coyle <[email protected]> * builder pattern Signed-off-by: Cassandra Coyle <[email protected]> * fix protoc Signed-off-by: Cassandra Coyle <[email protected]> * debug log levels for test containers Signed-off-by: Cassandra Coyle <[email protected]> * update readme and add debugging info Signed-off-by: Cassandra Coyle <[email protected]> * add IT test for cross app call activity Signed-off-by: Cassandra Coyle <[email protected]> * cleanup test Signed-off-by: Cassandra Coyle <[email protected]> * sysout -> ctx.logger Signed-off-by: Cassandra Coyle <[email protected]> * reset pom Signed-off-by: Cassandra Coyle <[email protected]> * rm debug lines from readme Signed-off-by: Cassandra Coyle <[email protected]> * fix header + rm customports Signed-off-by: Cassandra Coyle <[email protected]> * use consts Signed-off-by: Cassandra Coyle <[email protected]> * rm waitfor call Signed-off-by: Cassandra Coyle <[email protected]> * rm pubsub Signed-off-by: Cassandra Coyle <[email protected]> * rm timeout Signed-off-by: Cassandra Coyle <[email protected]> * reset empty lines added Signed-off-by: Cassandra Coyle <[email protected]> * reset appname for daprcontainer Signed-off-by: Cassandra Coyle <[email protected]> * reset empty line diff Signed-off-by: Cassandra Coyle <[email protected]> * rm constructor info from readme Signed-off-by: Cassandra Coyle <[email protected]> * debug -> info Signed-off-by: Cassandra Coyle <[email protected]> * rm super.start Signed-off-by: Cassandra Coyle <[email protected]> * reset dapr container diff Signed-off-by: Cassandra Coyle <[email protected]> * add test for codecov Signed-off-by: Cassandra Coyle <[email protected]> * up timeout time to unblock PR Signed-off-by: Cassandra Coyle <[email protected]> * deps: Update durabletask-client to 1.5.10 Signed-off-by: Javier Aliaga <[email protected]> * ci: Revert build timeout Signed-off-by: Javier Aliaga <[email protected]> * review: Use ctx.getLogger Signed-off-by: Javier Aliaga <[email protected]> * chore: Fix review comments Signed-off-by: Javier Aliaga <[email protected]> * chore: more review comments fixes Signed-off-by: Javier Aliaga <[email protected]> * test: Use testcontainers in CrossApp IT test Signed-off-by: Javier Aliaga <[email protected]> * chore: Load classpath for IT with all dependencies Signed-off-by: Javier Aliaga <[email protected]> --------- Signed-off-by: Cassandra Coyle <[email protected]> Signed-off-by: Javier Aliaga <[email protected]> Co-authored-by: Javier Aliaga <[email protected]> Signed-off-by: Javier Aliaga <[email protected]> * Release 1.16.0-rc-1 Signed-off-by: Dapr Bot <[email protected]> Signed-off-by: Javier Aliaga <[email protected]> * process deps too for dapr-spring (#1502) Signed-off-by: Cassandra Coyle <[email protected]> Signed-off-by: Javier Aliaga <[email protected]> * chore: Alpha components to stable Signed-off-by: Javier Aliaga <[email protected]> --------- Signed-off-by: Cassandra Coyle <[email protected]> Signed-off-by: Javier Aliaga <[email protected]> Signed-off-by: Matheus Cruz <[email protected]> Signed-off-by: Matheus Cruz <[email protected]> Signed-off-by: salaboy <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: artur-ciocanu <[email protected]> Signed-off-by: Artur Ciocanu <[email protected]> Signed-off-by: Dapr Bot <[email protected]> Co-authored-by: Cassie Coyle <[email protected]> Co-authored-by: Matheus Cruz <[email protected]> Co-authored-by: artur-ciocanu <[email protected]> Co-authored-by: salaboy <[email protected]> Co-authored-by: Siri Varma Vegiraju <[email protected]> Co-authored-by: Dapr Bot <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Artur Ciocanu <[email protected]> Co-authored-by: Dapr Bot <[email protected]>
Description
Change the configuration on documentation to camelCase.
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #1466
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: