-
Notifications
You must be signed in to change notification settings - Fork 223
rm protoc cmd from pom.xml #1498
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ion and results in a bad error Signed-off-by: Cassandra Coyle <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, does this mean that the Maven plugin will use its internal protoc version?
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1498 +/- ##
============================================
+ Coverage 76.91% 78.70% +1.78%
- Complexity 1592 1918 +326
============================================
Files 145 237 +92
Lines 4843 5926 +1083
Branches 562 610 +48
============================================
+ Hits 3725 4664 +939
- Misses 821 939 +118
- Partials 297 323 +26 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
* rm protoc cmd bc it uses a local protoc which might be the wrong version and results in a bad error Signed-off-by: Cassandra Coyle <[email protected]> * update protoc Signed-off-by: Cassandra Coyle <[email protected]> --------- Signed-off-by: Cassandra Coyle <[email protected]> Co-authored-by: artur-ciocanu <[email protected]> Co-authored-by: salaboy <[email protected]>
Locally I have a diff protoc version. That results in a crazy bad error. To not use a developers local protoc Im removing it so cmds like
mvn clean install
will run without error.I believe it fixes this issue or is at least a very similar err. See the err in the attached file.
protoc-issue.txt
Also noticed CI throwing: