Skip to content

add 'Cypress-Pro' plugin link #2747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jun 3, 2020
Merged

Conversation

mbolotov
Copy link
Contributor

'Cypress-Pro' plugin mention

@jennifer-shehane jennifer-shehane requested a review from a team April 27, 2020 06:27
@mbolotov
Copy link
Contributor Author

@JessicaSachs Appreciate any feedback.

Copy link
Contributor

@bencodezen bencodezen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need clarification on language to prevent confusion for IntelliJ users

@mbolotov mbolotov requested a review from bencodezen May 12, 2020 16:18
@bencodezen
Copy link
Contributor

@mbolotov Thanks for the update! After reviewing the plugin with the team, there are some issues with the plugin that need to be addressed:

  1. Change the logo - The new plugin currently uses the Cypress logo which can give users the impression that this is a plugin supported by the company rather than your plugin
  2. Change the name - The name of the plugin Cypress-Pro also gives the impression that users are paying Cypress for a service as opposed to you directly

Also, I apologize for the mistake, but I wasn't aware that the new plugin would be a paid service rather than a free one. We should add the original one back as the main one that users are directed to rather than the paid one.

If possible, it would be great to find a new plugin name that still highlights that it's for Cypress while giving credit to the fact that it's your tool rather than the company. Let me know if you have any additional questions, but I hope this helps!

@mbolotov
Copy link
Contributor Author

@bencodezen,
Good, I'll try to address the issues.
A few questions:

  1. Do you think Cypresso will be okay for the name of plugin?
  2. Should I change the name for the paid version only? So the open sourced version would still have Cypress mention in its name

@mbolotov
Copy link
Contributor Author

@bencodezen, could you please answer the questions above?

@Shelex
Copy link

Shelex commented May 18, 2020

This is interesting case actually.

IMHO: of course, Cypress has MIT license and commercial permission but it will be super strange if link to some paid service will be included as officially supported. As usual paid services provide free trial version or functionally limited package - and in such case it could be included into documentation (in this case - Cypress).

But I would also like to hear some official position (maybe @bahmutov ) about terms or regulations of plugins development and publicly available checklist for getting your plugin/tool/whatever added to documentation. For now it tells just to submit PR to plugins.yml - link. Another point - should these rules apply to existing plugins and how?

@amirrustam
Copy link
Contributor

Thanks for your input @Shelex. You can refer to @bencodezen for our official position on the plugin review process.

We do not mind linking to other services, and we applaud the developments within Cypress ecosystem by the community. Our primary concern with surfacing projects like this is to ensure that the plugin/project does not cause user confusion and that it is a high quality (well documented, well tested, etc.) offering.

@bencodezen
Copy link
Contributor

@mbolotov

Do you think Cypresso will be okay for the name of plugin?

After reviewing both versions, it would be best if you could keep the free version named similarly to the paid one so it is consistent on both ends.

Screen Shot 2020-05-18 at 12 07 36 PM

Following a similar method to VS Code extensions, by simply adding a qualifier to what your extension does (e.g., Cypress Helper) would better help to namespace the branding to prevent confusion from any official Cypress plugins that may be released in the future.

Let me know if you have any other questions!

Copy link
Contributor

@bencodezen bencodezen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Add free version back in to the documentation
  2. Change names of both versions to reduce confusion for users

@Shelex Shelex mentioned this pull request May 19, 2020
mbolotov added 2 commits June 1, 2020 19:35
1. change plugin names
2. revert base version link back
@mbolotov mbolotov requested a review from bencodezen June 1, 2020 16:39
@mbolotov
Copy link
Contributor Author

mbolotov commented Jun 1, 2020

@bencodezen
I've changed plugin names and removed the icon.
Could you please review?

@bencodezen
Copy link
Contributor

This is great @mbolotov! Once everything passes, I'll be happy to merge this. Thanks so much for being accommodating. Really appreciate it!

@bencodezen bencodezen merged commit c3347d2 into cypress-io:develop Jun 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants