-
Notifications
You must be signed in to change notification settings - Fork 1.1k
add 'Cypress-Pro' plugin link #2747
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@JessicaSachs Appreciate any feedback. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need clarification on language to prevent confusion for IntelliJ users
@mbolotov Thanks for the update! After reviewing the plugin with the team, there are some issues with the plugin that need to be addressed:
Also, I apologize for the mistake, but I wasn't aware that the new plugin would be a paid service rather than a free one. We should add the original one back as the main one that users are directed to rather than the paid one. If possible, it would be great to find a new plugin name that still highlights that it's for Cypress while giving credit to the fact that it's your tool rather than the company. Let me know if you have any additional questions, but I hope this helps! |
@bencodezen,
|
@bencodezen, could you please answer the questions above? |
This is interesting case actually. IMHO: of course, Cypress has MIT license and commercial permission but it will be super strange if link to some paid service will be included as officially supported. As usual paid services provide free trial version or functionally limited package - and in such case it could be included into documentation (in this case - Cypress). But I would also like to hear some official position (maybe @bahmutov ) about terms or regulations of plugins development and publicly available checklist for getting your plugin/tool/whatever added to documentation. For now it tells just to submit PR to plugins.yml - link. Another point - should these rules apply to existing plugins and how? |
Thanks for your input @Shelex. You can refer to @bencodezen for our official position on the plugin review process. We do not mind linking to other services, and we applaud the developments within Cypress ecosystem by the community. Our primary concern with surfacing projects like this is to ensure that the plugin/project does not cause user confusion and that it is a high quality (well documented, well tested, etc.) offering. |
After reviewing both versions, it would be best if you could keep the free version named similarly to the paid one so it is consistent on both ends. Following a similar method to VS Code extensions, by simply adding a qualifier to what your extension does (e.g., Cypress Helper) would better help to namespace the branding to prevent confusion from any official Cypress plugins that may be released in the future. Let me know if you have any other questions! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Add free version back in to the documentation
- Change names of both versions to reduce confusion for users
1. change plugin names 2. revert base version link back
@bencodezen |
This is great @mbolotov! Once everything passes, I'll be happy to merge this. Thanks so much for being accommodating. Really appreciate it! |
'Cypress-Pro' plugin mention