Skip to content

add allure plugin #2721

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 18, 2020
Merged

add allure plugin #2721

merged 3 commits into from
May 18, 2020

Conversation

Shelex
Copy link

@Shelex Shelex commented Apr 16, 2020

add link for allure reporter plugin
https://github.com/Shelex/cypress-allure-plugin

Copy link
Contributor

@gabrielbussolo gabrielbussolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @Shelex !
Thanks! 👍

@jennifer-shehane jennifer-shehane requested review from JessicaSachs and a team April 17, 2020 09:17
@jennifer-shehane
Copy link
Member

@gabrielferreirapro We have some more thorough review that we conduct on plugins before publishing. You can see the checks here: #2530 (review)

@Shelex Shelex closed this Apr 17, 2020
@Shelex Shelex reopened this Apr 17, 2020
@gabrielbussolo
Copy link
Contributor

@gabrielferreirapro We have some more thorough review that we conduct on plugins before publishing. You can see the checks here: #2530 (review)

Thank you! I will use it as a guide from now on. :bowtie:

@amirrustam amirrustam requested review from bencodezen and removed request for JessicaSachs May 14, 2020 02:38
@bencodezen
Copy link
Contributor

bencodezen commented May 15, 2020

👋 Hello and thank you for your contribution!

We are currently reviewing your plugin. As a heads up, we accept plugins that meet the following criteria:

  • 🚀 Works with the latest major version of Cypress (we can validate this once you have tests in place)
  • 🛠Plugin purpose is clearly documented (in a README or docs website)
  • 📄Well-written documentation - A great example (link)
  • 🔬Tests - Has tests that validate the primary function of the reporter
  • 👷‍♀️ CI pipeline that's passing (CircleCI and Github Actions are both free for Open Source)

We are currently blocked from reviewing your plugin since it requires tests before we can proceed. Let us know if you have any questions!

Copy link
Contributor

@bencodezen bencodezen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs tests in plugin repo before review can continue

@Shelex
Copy link
Author

Shelex commented May 18, 2020

@bencodezen Needs tests in plugin repo before review can continue

  • added tests
  • used Cypress 4.5.0
  • added badge for github-action workflow status.

@bencodezen
Copy link
Contributor

Thanks for the updates @Shelex!

@bencodezen bencodezen merged commit 1dbcc00 into cypress-io:develop May 18, 2020
@amirrustam
Copy link
Contributor

@Shelex thank you for contributing this plugin 🙏

@Shelex
Copy link
Author

Shelex commented May 19, 2020

@amirrustam Thanks!
Btw, based on #2747 (comment) should I replace cypress logo for Cypress Helper vscode extension?

@amirrustam
Copy link
Contributor

That would be preferable, and a good long-term move in case our logo changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants