Skip to content

fix(grpc): add sanity check in TraceTx and TraceCall #657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 4, 2025
Merged

fix(grpc): add sanity check in TraceTx and TraceCall #657

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c10c39c
add sanity check in tracetx
thomas-nguy Jul 4, 2025
e15ae6d
update changelog
thomas-nguy Jul 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,8 @@ Ref: https://keepachangelog.com/en/1.0.0/

### Features

* (rpx) [#629](https://github.com/crypto-org-chain/ethermint/pull/629) Add support for eth_getBlockReceipts.
* (rpc) [#657](https://github.com/crypto-org-chain/ethermint/pull/657) Sanity checks for TraceTx and TraceCall.
* (rpc) [#629](https://github.com/crypto-org-chain/ethermint/pull/629) Add support for eth_getBlockReceipts.
* (evm) [#414](https://github.com/crypto-org-chain/ethermint/pull/414) Integrate go-block-stm for parallel tx execution.
* (block-stm) [#498](https://github.com/crypto-org-chain/ethermint/pull/498) Enable incarnation cache for block-stm executor.

Expand Down
8 changes: 7 additions & 1 deletion x/evm/keeper/grpc_query.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -488,7 +488,10 @@
// be tracer dependent.
func (k Keeper) TraceTx(c context.Context, req *types.QueryTraceTxRequest) (*types.QueryTraceTxResponse, error) {
var baseFee *big.Int
if req != nil && req.BaseFee != nil {
if req == nil || req.Msg == nil {
return nil, status.Error(codes.InvalidArgument, "request and message cannot be empty")
}
if req.BaseFee != nil {
baseFee = big.NewInt(req.BaseFee.Int64())
}
resultData, err := execTrace(
Expand Down Expand Up @@ -614,6 +617,9 @@
// executes the given call in the provided environment. The return value will
// be tracer dependent.
func (k Keeper) TraceCall(c context.Context, req *types.QueryTraceCallRequest) (*types.QueryTraceCallResponse, error) {
if req == nil {
return nil, status.Error(codes.InvalidArgument, "request cannot be empty")
}

Check warning on line 622 in x/evm/keeper/grpc_query.go

View check run for this annotation

Codecov / codecov/patch

x/evm/keeper/grpc_query.go#L620-L622 

Added lines #L620 - L622 were not covered by tests
resultData, err := execTrace(
c,
req,
Expand Down
Loading