Skip to content

Conversation

thomas-nguy
Copy link

Closes: #XXX

Description


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@thomas-nguy thomas-nguy force-pushed the thomas/sanity-check-tracetx branch from fba184d to c10c39c Compare July 4, 2025 07:32
@thomas-nguy thomas-nguy changed the title fix(grpc): add sanity check in TraceTx fix(grpc): add sanity check in TraceTx and TraceCall Jul 4, 2025
@songgaoye songgaoye self-requested a review July 4, 2025 07:40
Copy link

codecov bot commented Jul 4, 2025

Codecov Report

Attention: Patch coverage is 42.85714% with 4 lines in your changes missing coverage. Please review.

Project coverage is 46.13%. Comparing base (823fc68) to head (e15ae6d).
Report is 1 commits behind head on release/v1.4.x-2.

Files with missing lines Patch % Lines
x/evm/keeper/grpc_query.go 42.85% 3 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@                 Coverage Diff                  @@
##           release/v1.4.x-2     #657      +/-   ##
====================================================
- Coverage             46.14%   46.13%   -0.02%     
====================================================
  Files                   181      181              
  Lines                 18216    18222       +6     
====================================================
  Hits                   8406     8406              
- Misses                 9085     9090       +5     
- Partials                725      726       +1     
Files with missing lines Coverage Δ
x/evm/keeper/grpc_query.go 76.56% <42.85%> (-0.84%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@thomas-nguy thomas-nguy enabled auto-merge (squash) July 4, 2025 07:43
@thomas-nguy thomas-nguy merged commit ae39ef3 into crypto-org-chain:release/v1.4.x-2 Jul 4, 2025
40 of 43 checks passed
thomas-nguy added a commit that referenced this pull request Jul 8, 2025
* fix(grpc): add sanity check in TraceTx and TraceCall (#657)

* fix(grpc): add sanity check in Trace_Tx follow up

* update changelog

* update changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants