Skip to content

Conversation

thomas-nguy
Copy link

@thomas-nguy thomas-nguy commented Jun 17, 2025

Closes: #621

TODO: add test on Cronos

Description


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@thomas-nguy thomas-nguy requested review from JayT106 and XinyuCRO June 17, 2025 06:12
Copy link

codecov bot commented Jun 17, 2025

Codecov Report

Attention: Patch coverage is 52.27273% with 21 lines in your changes missing coverage. Please review.

Project coverage is 46.14%. Comparing base (434f46d) to head (e29673e).
Report is 1 commits behind head on release/v1.4.x-2.

Files with missing lines Patch % Lines
rpc/backend/blocks.go 60.60% 9 Missing and 4 partials ⚠️
rpc/backend/tx_info.go 42.85% 3 Missing and 1 partial ⚠️
rpc/namespaces/ethereum/eth/api.go 0.00% 4 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@                 Coverage Diff                  @@
##           release/v1.4.x-2     #629      +/-   ##
====================================================
- Coverage             46.15%   46.14%   -0.01%     
====================================================
  Files                   181      181              
  Lines                 18182    18216      +34     
====================================================
+ Hits                   8391     8406      +15     
- Misses                 9071     9085      +14     
- Partials                720      725       +5     
Files with missing lines Coverage Δ
rpc/backend/backend.go 78.94% <ø> (ø)
rpc/backend/tx_info.go 58.14% <42.85%> (+0.11%) ⬆️
rpc/namespaces/ethereum/eth/api.go 0.00% <0.00%> (ø)
rpc/backend/blocks.go 76.44% <60.60%> (-2.32%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@thomas-nguy thomas-nguy requested a review from XinyuCRO June 17, 2025 10:49
@thomas-nguy thomas-nguy force-pushed the thomas/eth-getblockreceipts branch from 26cdea1 to e7e74cd Compare June 18, 2025 00:46
@thomas-nguy thomas-nguy enabled auto-merge (squash) June 18, 2025 06:51
@thomas-nguy thomas-nguy merged commit 823fc68 into crypto-org-chain:release/v1.4.x-2 Jun 18, 2025
29 of 31 checks passed
@thomas-nguy thomas-nguy deleted the thomas/eth-getblockreceipts branch June 18, 2025 06:52
thomas-nguy added a commit that referenced this pull request Jun 23, 2025
* feat: add support for eth_getBlockReceipts (#629)

* add support for eth_getblockreceipts

* update changelog

* Update rpc/backend/blocks.go

Co-authored-by: Xinyu <[email protected]>
Signed-off-by: Thomas Nguy <[email protected]>

* fix lint

* optimization

* remove empty space

* add test case

* fix length and add test

* return err details

* fix tests

* fix lint

* fix tests

---------

Signed-off-by: Thomas Nguy <[email protected]>
Co-authored-by: Xinyu <[email protected]>

* update changelog

---------

Signed-off-by: Thomas Nguy <[email protected]>
Co-authored-by: Xinyu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants