Skip to content

Conversation

thomas-nguy
Copy link

@thomas-nguy thomas-nguy commented Jun 18, 2025

Closes: #621

Description

Backport from release/v1.4.x-2


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

thomas-nguy and others added 2 commits June 18, 2025 15:53
* add support for eth_getblockreceipts

* update changelog

* Update rpc/backend/blocks.go

Co-authored-by: Xinyu <[email protected]>
Signed-off-by: Thomas Nguy <[email protected]>

* fix lint

* optimization

* remove empty space

* add test case

* fix length and add test

* return err details

* fix tests

* fix lint

* fix tests

---------

Signed-off-by: Thomas Nguy <[email protected]>
Co-authored-by: Xinyu <[email protected]>
@thomas-nguy thomas-nguy requested review from JayT106 and XinyuCRO June 18, 2025 06:56
Copy link

codecov bot commented Jun 18, 2025

Codecov Report

Attention: Patch coverage is 52.27273% with 21 lines in your changes missing coverage. Please review.

Project coverage is 46.13%. Comparing base (fac790e) to head (50e6160).
Report is 23 commits behind head on develop.

Files with missing lines Patch % Lines
rpc/backend/blocks.go 60.60% 9 Missing and 4 partials ⚠️
rpc/backend/tx_info.go 42.85% 3 Missing and 1 partial ⚠️
rpc/namespaces/ethereum/eth/api.go 0.00% 4 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #638      +/-   ##
===========================================
- Coverage    46.14%   46.13%   -0.01%     
===========================================
  Files          181      181              
  Lines        18183    18217      +34     
===========================================
+ Hits          8390     8405      +15     
- Misses        9073     9087      +14     
- Partials       720      725       +5     
Files with missing lines Coverage Δ
rpc/backend/backend.go 78.94% <ø> (ø)
rpc/backend/tx_info.go 58.14% <42.85%> (+0.11%) ⬆️
rpc/namespaces/ethereum/eth/api.go 0.00% <0.00%> (ø)
rpc/backend/blocks.go 76.44% <60.60%> (-2.32%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@thomas-nguy thomas-nguy merged commit ee43f56 into crypto-org-chain:develop Jun 23, 2025
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat: support eth_getBlockReceipts endpoint

3 participants