forked from evmos/ethermint
    
        
        - 
                Notifications
    You must be signed in to change notification settings 
- Fork 52
Problem: evm transfer is not efficient #448
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Merged
      
      
    
                
     Merged
            
            
          Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
    
              
                    yihuang
  
              
              commented
              
                  
                    Apr 2, 2024 
                  
              
              
            
            
| Codecov ReportAttention: Patch coverage is  
 Additional details and impacted files@@             Coverage Diff             @@
##           develop     #448      +/-   ##
===========================================
- Coverage    63.29%   63.23%   -0.07%     
===========================================
  Files          125      125              
  Lines        12075    12097      +22     
===========================================
+ Hits          7643     7649       +6     
- Misses        3889     3900      +11     
- Partials       543      548       +5     
 | 
      
        
      
      
  
    12 tasks
  
              
                    yihuang
  
              
              commented
              
                  
                    Apr 2, 2024 
                  
              
              
            
            
              
                    mmsqe
  
              
              reviewed
              
                  
                    Apr 2, 2024 
                  
              
              
            
            
Solution: - override the Transfer callback in block context. Update CHANGELOG.md Signed-off-by: yihuang <[email protected]> test reverted sdk update deps align input checks
              
                    mmsqe
  
              
              approved these changes
              
                  
                    Apr 2, 2024 
                  
              
              
            
            
    
  zsystm 
      pushed a commit
        to b-harvest/ethermint
      that referenced
      this pull request
    
      Jun 10, 2024 
    
    
      
  
    
      
    
  
…-chain#448) Reason for Cherry-pick: - Required patch for migrating Block STM (Parallel Transaction Execution) - Avoid common conflict problem when transfer eth Notes - (bug) While cherry-picking necessary one, I'm trying to implement native state revert using only SDK's store functions, but some error occurs. Need to fix it. - (refactor) Refactored test codes by referencing Cronos because it is more clean and maintainable Original Commit Message: * Problem: evm transfer is not efficient Solution: - override the Transfer callback in block context. Update CHANGELOG.md Signed-off-by: yihuang <[email protected]> * test reverted sdk * update deps --------- Signed-off-by: yihuang <[email protected]> Cherry-picked-by: zsystm <[email protected]>
  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment
  
      
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
Description
Solution:
This makes crypto-org-chain/cosmos-sdk#239 unnecessary, will revert later.
For contributor use:
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerFor admin use:
WIP,R4R,docs, etc)