Skip to content

Problem: no efficient bank api to support evm add/sub balances #239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 29, 2024
Merged

Problem: no efficient bank api to support evm add/sub balances #239

merged 2 commits into from
Mar 29, 2024

Conversation

@yihuang
Copy link

@yihuang yihuang commented Mar 28, 2024 •
edited
Loading

Description

Add AddBalance/SubBalance low level api to bank keeper, to support evm integration more efficiently.

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • reviewed "Files changed" and left comments if necessary
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • updated the relevant documentation or specification, including comments for documenting Go code
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic, API design and naming, documentation is accurate, tests and test coverage

yihuang
yihuang commented Mar 28, 2024
View reviewed changes
@yihuang yihuang requested a review from mmsqe March 28, 2024 05:03
@yihuang yihuang enabled auto-merge (squash) March 28, 2024 06:11
Problem: no efficient bank api to support evm add/sub balances
f3146d3 
fix

Update CHANGELOG.md

Signed-off-by: yihuang <[email protected]>

don't change interface
mmsqe
mmsqe reviewed Mar 29, 2024
View reviewed changes
@yihuang yihuang merged commit b693dd9 into crypto-org-chain:release/v0.50.x Mar 29, 2024
@yihuang yihuang deleted the add-sub branch March 29, 2024 07:06
@yihuang yihuang mentioned this pull request Apr 2, 2024
Merged
11 tasks
yihuang pushed a commit that referenced this pull request Apr 2, 2024
Revert "Problem: no efficient bank api to support evm add/sub balances (
829c542 
#239)" (#247)

This reverts commit b693dd9.
@JayT106 JayT106 mentioned this pull request May 8, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@mmsqe mmsqe mmsqe approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

C:x/bank

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@yihuang @mmsqe