Skip to content

Use PIPE instead of capture_output to support python3.6 #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 11, 2022
Merged

Use PIPE instead of capture_output to support python3.6 #36

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions clang_tools/install.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
import shutil
import subprocess
import sys
from typing import Optional, Union
from typing import Optional

from . import install_os, RESET_COLOR, suffix, YELLOW
from .util import download_file, verify_sha512, get_sha_checksum
Expand Down Expand Up @@ -38,7 +38,7 @@ def is_installed(tool_name: str, version: str) -> Optional[Path]:
)
try:
result = subprocess.run(
[exe_name, "--version"], capture_output=True, check=True
[exe_name, "--version"], stdout=subprocess.PIPE, stderr=subprocess.PIPE, check=True
)
except (FileNotFoundError, subprocess.CalledProcessError):
return None # tool is not installed
Expand Down