Use PIPE instead of capture_output to support python3.6

[shenxianpeng]

Python 3.6 does not has capture_output https://docs.python.org/3.6/library/subprocess.html, use subprocess.PIPE instead can fix this problem.

I have donwload new build wheel and install on my python3.6 env, it works now.

It would be best to include test on python3.6 with GitHub action if we support py36 in later release.

Fix #34

[2bndy5]

python 3.6 is no longer maintained and is deemed deprecated.

[2bndy5]

This isn't totally equivalent, but I think it will work in this case.

According to the docs:

If capture_output is true, stdout and stderr will be captured. When used, the internal Popen object is automatically created with stdout=PIPE and stderr=PIPE. The stdout and stderr arguments may not be supplied at the same time as capture_output. If you wish to capture and combine both streams into one, use stdout=PIPE and stderr=STDOUT instead of capture_output.

Meaning, if you want to apply this change to cpp-linter pkg's use of subprocess.run(), then you'de have to use

result = subprocess.run(cmds, stdout=subprocess.PIPE, stderr=subprocess.PIPE)

because we actually use the stderr output in the cpp-linter pkg.

[shenxianpeng]

python 3.6 is no longer maintained and is deemed deprecated.

You're right. https://endoflife.date/python. OK, we do not need to test on python3.6.

[2bndy5]

I'm ok with using this patch. Not all users are keen to keeping their python version in the CI up-to-date.

[codecov-commenter]

Codecov Report

Merging #36 (2065aaf) into main (aeee5f6) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main      #36   +/-   ##
=======================================
  Coverage   87.71%   87.71%           
=======================================
  Files           4        4           
  Lines         171      171           
=======================================
  Hits          150      150           
  Misses         21       21           

Impacted Files	Coverage Δ
clang_tools/install.py	82.69% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[shenxianpeng]

Updated. sure, it would be nice if users of the old python version also could use it 😃