Skip to content

Improvements and bugfixes #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 9, 2022
Merged

Improvements and bugfixes #31

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
845d0bc
improvements and bugfixes
petrparolek Jan 25, 2022
14e430c
phpstan++
petrparolek Jan 27, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ csf:
vendor/bin/phpcbf --standard=ruleset.xml --extensions=php,phpt --tab-width=4 --ignore=temp -sp src tests

phpstan:
vendor/bin/phpstan analyse -l max -c phpstan.neon --memory-limit=512M src
vendor/bin/phpstan analyse -c phpstan.neon --memory-limit=512M

tests:
vendor/bin/tester -s -p php --colors 1 -C tests
Expand Down
6 changes: 3 additions & 3 deletions composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,9 +44,9 @@
"nette/tester": "^2.4.0",
"tracy/tracy": "^2.8.0",
"mockery/mockery": "^1.3.0",
"phpstan/phpstan": "^0.12",
"phpstan/phpstan-strict-rules": "^0.12",
"ninjify/coding-standard": "^0.12"
"phpstan/phpstan": "^1.0",
"phpstan/phpstan-strict-rules": "^1.0",
"ninjify/coding-standard": "^0.11"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Proc 0.11?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

opravím

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

root@7c4d2bf04b30:~/repos/contributte-datagrid-nette-database-data-source# make qa
vendor/bin/phpstan analyse -l 8 -c phpstan.neon --memory-limit=512M src
 3/3 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%


                                                                                                                        
 [OK] No errors                                                                                                         
                                                                                                                        

vendor/bin/phpcs --standard=ruleset.xml --extensions=php,phpt --tab-width=4 --ignore=temp -sp src tests
ERROR: Referenced sniff "SlevomatCodingStandard.Namespaces.FullyQualifiedClassNameAfterKeyword" does not exist

Run "phpcs --help" for usage information

make: *** [Makefile:9: cs] Error 3

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Odmaz FullyQualifiedClassNameAfterKeyword z ruleset.xml a pripadne dalsi co delaji problemy.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

jak? Vždyt toto tam není

},
"prefer-stable": true,
"minimum-stability": "dev",
Expand Down
3 changes: 3 additions & 0 deletions phpstan.neon
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,9 @@ includes:
- ./vendor/phpstan/phpstan-strict-rules/rules.neon

parameters:
level: 8
paths:
- src
ignoreErrors:
- '#^Strict comparison using === between string and null will always evaluate to false.$#'
- '#^Parameter \#1 \$sql of method Nette\\Database\\Explorer::query\(\) expects literal-string, mixed given.$#'