Improvements and bugfixes #31
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
petrparolek
commented
Jan 25, 2022
petrparolek
commented
- upgraded PHPStan
- downgraded ninjify/coding-standard
- upgraded PHPStan - downgraded ninjify/coding-standard
f3l1x
reviewed
Jan 27, 2022
| "ninjify/coding-standard": "^0.12" | ||
| "phpstan/phpstan": "^1.0", | ||
| "phpstan/phpstan-strict-rules": "^1.0", | ||
| "ninjify/coding-standard": "^0.11" |
There was a problem hiding this comment.
root@7c4d2bf04b30:~/repos/contributte-datagrid-nette-database-data-source# make qa
vendor/bin/phpstan analyse -l 8 -c phpstan.neon --memory-limit=512M src
3/3 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%
[OK] No errors
vendor/bin/phpcs --standard=ruleset.xml --extensions=php,phpt --tab-width=4 --ignore=temp -sp src tests
ERROR: Referenced sniff "SlevomatCodingStandard.Namespaces.FullyQualifiedClassNameAfterKeyword" does not exist
Run "phpcs --help" for usage information
make: *** [Makefile:9: cs] Error 3
There was a problem hiding this comment.
Odmaz FullyQualifiedClassNameAfterKeyword z ruleset.xml a pripadne dalsi co delaji problemy.
There was a problem hiding this comment.
jak? Vždyt toto tam není
f3l1x
reviewed
Jan 27, 2022
Makefile
Outdated
|
|
||
| phpstan: | ||
| vendor/bin/phpstan analyse -l max -c phpstan.neon --memory-limit=512M src | ||
| vendor/bin/phpstan analyse -l 8 -c phpstan.neon --memory-limit=512M src |
f3l1x
reviewed
Jan 28, 2022
petrparolek
force-pushed
the
petrparolek-patch-1
branch
from
f3b7bc6 to
14e430c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.