-
Notifications
You must be signed in to change notification settings - Fork 46
common: add support for default_host_ips in containers.conf
#422
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -634,6 +634,13 @@ type NetworkConfig struct { | |
| // PastaOptions contains a default list of pasta(1) options that should | ||
| // be used when running pasta. | ||
| PastaOptions attributedstring.Slice `toml:"pasta_options,omitempty"` | ||
|
|
||
| // DefaultHostIPs is the default host IPs to bind published container ports | ||
| // to when no host IP is explicitly specified in the -p flag (e.g., -p 80:80). | ||
| // If empty, the default behavior is to bind to all interfaces (0.0.0.0). | ||
| // If multiple IPs are specified, separate port mapping for each of the specified | ||
| // IP would be created. | ||
| DefaultHostIPs []string `toml:"default_host_ips,omitempty"` | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. this should use attributedstring.Slice like other array to support appending accordingly Also not trying to bikeshed but I wonder if |
||
| } | ||
|
|
||
| type SubnetPool struct { | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo here with
--