common: add support for default_host_ips in containers.conf
#422
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
podmanbot
pushed a commit
to podmanbot/buildah
that referenced
this pull request
Oct 28, 2025
|
✅ A new PR has been created in buildah to vendor these changes: containers/buildah#6458 |
Member
|
LGTM |
mtrmac
reviewed
Oct 30, 2025
|
Just out of curiosity: was DefaultHostIP already a thing and it just needed to be exposed as default_host_ip in containers.conf? |
Luap99
reviewed
Nov 3, 2025
Member
Luap99
left a comment
Luap99
left a comment
There was a problem hiding this comment.
This also needs a basic unit test to confirm the option is getting parsed properly.
danishprakash
force-pushed
the
default-host-ip
branch
from
2429193 to
6be2cf2
Compare
podmanbot
pushed a commit
to podmanbot/buildah
that referenced
this pull request
Nov 13, 2025
danishprakash
changed the title
default_host_ip in containers.confdefault_host_ips in containers.conf
danishprakash
force-pushed
the
default-host-ip
branch
from
6be2cf2 to
d3a47c2
Compare
This adds support for configuring default host IPs via containers.conf to bind published container ports to when no host IP is explicitly specified (e.g. -p 8000:8000). If multiple IPs are specified, separate port mapping for each of the specified IP would be created. For instance, setting this to `["127.0.0.1", "::1"]` and port specified as `-p 8080:80` will result into two port mappings in podman-- `127.0.0.1:8080:80` and `[::1]:8080:80`. Note that explicit host IP still overrides the default option set in containers.conf. Refers containers/podman#27186 Signed-off-by: Danish Prakash <[email protected]>
danishprakash
force-pushed
the
default-host-ip
branch
from
d3a47c2 to
8c23523
Compare
podmanbot
pushed a commit
to podmanbot/buildah
that referenced
this pull request
Nov 13, 2025
podmanbot
pushed a commit
to podmanbot/buildah
that referenced
this pull request
Nov 13, 2025
Luap99
reviewed
Nov 18, 2025
Member
Luap99
left a comment
Luap99
left a comment
There was a problem hiding this comment.
Please also add a basic test to ensure the field is parsed properly.
| // If empty, the default behavior is to bind to all interfaces (0.0.0.0). | ||
| // If multiple IPs are specified, separate port mapping for each of the specified | ||
| // IP would be created. | ||
| DefaultHostIPs []string `toml:"default_host_ips,omitempty"` |
Member
There was a problem hiding this comment.
this should use attributedstring.Slice like other array to support appending accordingly
Also not trying to bikeshed but I wonder if default_host_ips is the best name here? Should it be default_publish_ips or default_port_bind_ips? HostIP IMO could be assumed to be something else unrelated to port mappings, i.e. we already have host_containers_internal_ip for example.
Luap99
reviewed
Nov 18, 2025
| behavior is to bind to all network interfaces (`0.0.0.0`). If multiple IPs are specified, | ||
| separate port mapping for each of the specified IP would be created. For instance, setting | ||
| this to `["127.0.0.1", "::1"]` and port specified as `-p 8080:80` will result into two | ||
| port mappings in podman--`127.0.0.1:8080:80` and `[::1]:8080:80`. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for configuring a default host IP via containers.conf to bind published container ports to when no host IP is explicitly specified (e.g. -p 8000:8000). Note that explicit host IP still overrides the default option set in containers.conf.
Refers containers/podman#27186