Skip to content

[CI] Kube test: wait for image #4357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 24, 2025
Merged

[CI] Kube test: wait for image #4357

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions cmd/nerdctl/container/container_commit_linux_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ package container
import (
"strings"
"testing"
"time"

"github.com/containerd/nerdctl/mod/tigron/test"
"github.com/containerd/nerdctl/mod/tigron/tig"
Expand Down Expand Up @@ -55,6 +56,20 @@ func TestKubeCommitSave(t *testing.T) {

testCase.Command = func(data test.Data, helpers test.Helpers) test.TestableCommand {
helpers.Ensure("commit", data.Labels().Get("containerID"), data.Identifier("testcommitsave"))
// Wait for the image to show up
for range 5 {
found := false
cmd := helpers.Command("images", data.Identifier("testcommitsave"), "--format", "json")
cmd.Run(&test.Expected{
Output: func(stdout string, t tig.T) {
found = strings.TrimSpace(stdout) != ""
},
})
if found {
break
}
time.Sleep(1 * time.Second)
}
return helpers.Command("save", data.Identifier("testcommitsave"))
}

Expand Down