Skip to content

Conversation

@apostasie
Copy link
Contributor

Tentatively fix #4106

@apostasie
Copy link
Contributor Author

Unrelated failures are:

@apostasie apostasie closed this Jun 23, 2025
@apostasie apostasie reopened this Jun 23, 2025
This was referenced Jun 23, 2025
@apostasie
Copy link
Contributor Author

Rebased on principles.

Signed-off-by: apostasie <[email protected]>
@AkihiroSuda AkihiroSuda added this to the v2.1.3 milestone Jun 24, 2025
Copy link
Member

@AkihiroSuda AkihiroSuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, but this seems to be a bug of nerdctl commit?
It should be just synchronous?

@AkihiroSuda AkihiroSuda merged commit d0d1c2d into containerd:main Jun 24, 2025
62 of 64 checks passed
@apostasie
Copy link
Contributor Author

Thanks, but this seems to be a bug of nerdctl commit? It should be just synchronous?

Commit is definitely synchronous in a basic setup - but somehow not with kind+kube.

I do not know in enough details how kube would work on that ^.
Do you believe it could explain our issue?

The alternative explanation would be that commit is failing silently (in that case we will still see the failure if this patch does not address the issue)

@ningmingxiao
Copy link
Contributor

can we show contaierd log ? when ci failed.

@apostasie
Copy link
Contributor Author

can we show contaierd log ? when ci failed.

Yeah, this is growingly necessary...
Let me see what I can do.

@apostasie
Copy link
Contributor Author

#4365

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[CI]: Kube failure on commit + save

3 participants