Skip to content

Conversation

@apostasie
Copy link
Contributor

Fix #3914

@apostasie apostasie changed the title Disable golangci preflight config validation CI: disable golangci preflight config validation Feb 23, 2025
@apostasie apostasie force-pushed the ci-golangci-disable-config-validation branch from b519491 to 4c32c64 Compare February 25, 2025 00:52
@apostasie
Copy link
Contributor Author

Rebased.

@apostasie apostasie force-pushed the ci-golangci-disable-config-validation branch from 4c32c64 to cec4a34 Compare February 25, 2025 16:35
@apostasie apostasie force-pushed the ci-golangci-disable-config-validation branch from cec4a34 to 7fcde18 Compare February 26, 2025 01:01
@apostasie
Copy link
Contributor Author

Rebased.
@AkihiroSuda Let's have this one in at your convenience - one less source of flake on the CI...

@AkihiroSuda AkihiroSuda added this to the v2.0.4 milestone Feb 26, 2025
@AkihiroSuda AkihiroSuda added the area/ci e.g., CI failure label Feb 26, 2025
Copy link
Member

@AkihiroSuda AkihiroSuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@apostasie
Copy link
Contributor Author

apostasie commented Feb 26, 2025

Unrelated - but looks like diff may be flaky.

I see that I already disabled parallelism on target docker. Might have to disable it as well for nerdctl.

@AkihiroSuda why would diff flake out though? Is it expected that we would have to sync or something?

Update: just had a look at the diff code. I will pretend this CI failure never happened and that I did not see it. :-D

@djdongjin djdongjin merged commit 499f905 into containerd:main Mar 1, 2025
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/ci e.g., CI failure

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CI: golangci-lint config validation is useless and flaky

3 participants