Skip to content

Conversation

@apostasie
Copy link
Contributor

@apostasie apostasie commented Feb 16, 2025

This is on top of #3889 (on top of #3591) - should be merged in order.

This specific PR does cleanup and reorganize the testutil/test package.

Although this PR looks "large", it is not functionally changing anything (and is only touching tests and testing tools anyhow).

The key take-aways here are:

  • move the new test module to its final destination (mod/tigron)
  • split overcrowded module into more intuitive sub-packages:
    • expect (expect.Contains, expect.Match, expect.ExitCode)
    • require (require.Arm64, etc)
    • test (test.Case, etc)
  • renamed some methods to more intuitive names (eg: test.Require becomes require.All)

A tigron is a tigon in french :) (the offspring of a tiger and a lion)

The next PR after that will focus on linting code with more stringent standards.

@apostasie apostasie force-pushed the sub-project-testing-2 branch 3 times, most recently from 7363284 to 2f941a6 Compare February 21, 2025 23:05
@apostasie apostasie changed the title [WIP] Test framework, part II Test framework, part II Feb 22, 2025
@apostasie apostasie marked this pull request as ready for review February 22, 2025 00:25
@apostasie apostasie marked this pull request as draft February 22, 2025 04:47
@apostasie apostasie force-pushed the sub-project-testing-2 branch from 2f941a6 to 472a2b0 Compare February 22, 2025 20:00
@apostasie apostasie changed the title Test framework, part II [PENDING DEPENDENT] Test framework, part II Feb 22, 2025
@apostasie apostasie changed the title [PENDING DEPENDENT] Test framework, part II [PENDING DEPENDENT] CI: test framework, part II Feb 23, 2025
@apostasie
Copy link
Contributor Author

CI failure is #3914 - to be addressed by #3915

@apostasie apostasie force-pushed the sub-project-testing-2 branch from 472a2b0 to e4b5b26 Compare February 24, 2025 17:34
@apostasie apostasie changed the title [PENDING DEPENDENT] CI: test framework, part II CI: test framework, part II Feb 24, 2025
@apostasie apostasie marked this pull request as ready for review February 24, 2025 17:43
@apostasie apostasie force-pushed the sub-project-testing-2 branch from e4b5b26 to 8474bbd Compare February 24, 2025 18:37
@apostasie apostasie marked this pull request as draft February 26, 2025 03:03
Signed-off-by: apostasie <[email protected]>
@apostasie apostasie force-pushed the sub-project-testing-2 branch from 8474bbd to 4b765cd Compare February 26, 2025 03:31
@apostasie apostasie marked this pull request as ready for review February 26, 2025 05:18
@AkihiroSuda AkihiroSuda added this to the v2.0.4 milestone Feb 27, 2025
@AkihiroSuda AkihiroSuda added the area/ci e.g., CI failure label Feb 27, 2025
Copy link
Member

@AkihiroSuda AkihiroSuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@AkihiroSuda AkihiroSuda merged commit d307278 into containerd:main Feb 27, 2025
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/ci e.g., CI failure

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants